Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code clean up from Sonar Cloud analysis #2068

Merged
merged 45 commits into from
Jan 1, 2023
Merged

Code clean up from Sonar Cloud analysis #2068

merged 45 commits into from
Jan 1, 2023

Conversation

tastybento
Copy link
Member

No description provided.

@tastybento
Code clean up from Sonar Cloud analysis
67cc125
@tastybento
Fix tests
4364d72
@tastybento
Remove code smell
4542e97
@tastybento
Rename "island" which hides the field declared at line 25.
a768a1f
@tastybento
Removed code smells.
b4aa4e8
@tastybento
Rename variable record to rec
ea5131e 
Renamed "record" variable to not match a restricted identifier.
Restricted Identifiers should not be used as identifiers. "record" is
using in Java 16.
@tastybento
Added private constructor to prevent instantiation of static class
dbb4c24 
Changed variable name to rec instead of restricted "record".
@tastybento
Remove Blueprint code smells.
c8fbbc9
@tastybento
Use a record for database settings constructor
3741322 
Code smell: Methods should not have too many parameters. I'm not sure
what methods are using this class though.
@tastybento
Update MyWorlds version
5bda2b0 
The POM for MyWorlds is invalid and causes a warning, but this still
persists with this version.
@tastybento
Extracted nested try block into a separate method.
f4c043b 
Makes it clear when reading the code what might be caught
@tastybento
Extracted nested try block into a separate method.
90d8b02
@tastybento
Fixed JavaDoc /** instead of just /*
76801b2
@tastybento
Extracted nested try block into a separate method.
a270b5f
@tastybento
Refactored to not assign loop counter from within the loop body.
9220f0c
@tastybento
Better delete option. With results.
4e46e8f 
That said, this is legacy code to handle an issue that occurred a long
time ago and this whole set of code can probably be removed.
@tastybento
Catch Exceptions not Throwable
08881c0
@tastybento
Log error with BentoBox logError
1fd7688
@tastybento
Use computeIfAbsent
0090f91 
Using these instead leads to cleaner and more readable code.
@tastybento
User can no longer be null
bd0411b
@tastybento
Added the missing @deprecated annotation and @SInCE ref
d270220
@tastybento
Added @SInCE reference
0b918c7
@tastybento
Merge if statements
f509d30
@tastybento
Use BentoBox error logging.
bb31138
@tastybento
Added JavaDoc @SInCE
4260965
@tastybento
Remove deprecated class and move used class
24a865b
@tastybento
Remove deprecated WoodType and use Type.
ca6d716
@tastybento
Remove unused import
79241e3
@tastybento
Extracted nested try block into a separate method.
9c83f4d
@tastybento
Comment empty default statement
db0b798
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@tastybento tastybento merged commit 056cff4 into develop Jan 1, 2023
@BONNe BONNe deleted the code_clean branch January 3, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tastybento