Add more generic version for BlockEndDragon class. #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use max world height instead of magic 255 value.
Poslovitch
approved these changes
Dec 6, 2021
|
Build is failing due to the Sonar job, but the code is properly building and tested. |
tastybento
added a commit
that referenced
this pull request
Dec 13, 2021
* Update to Minecraft 1.18 (#1887) * Make BlockEndDragon support custom max world height (#1888) Use max world height instead of magic 255 value. * Send PVP toggle messages only to on-island players. #1885 * Add 1.18.1 Co-authored-by: BONNe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use max world height instead of magic 255 value.
Currently, there is no issue with world height as the end is still 256 blocks height, but there are data packs and options to change it now.