Adds maxMembers to the Island object for persistent storage #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tastybento
added
the
Type: Enhancement
|
Weren't there also max trusted and max coop numbers? |
|
Good point. In that case, maybe a Rank,Max map will be more flexible. That can then be expanded to include ban maxes and limit any other ranks. |
This updates the island's settings based on the owner's permissions.
|
Okay, should be done now. I also added the checks to fix the #1690 bug. |
|
@BONNe What do you think? |
BONNe
approved these changes
Feb 27, 2021
|
I approve changes. I look through it and everything looked correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1690
The goal is to store the maximum number of members an island can have in the island object. The IslandsManager provides a method to obtain this value that also updates it based on the online owner's permissions or default value for the world if the max value is undefined. If there is no value different to the default world value then nothing has to be stored.