Switch to island homes from player homes. #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stores home locations and max homes in the Island object. Adds commands required to manage home names, specifically rename and delete. I did not add list as there is tab complete on island go, but it may be required. To Do: 1. Test 2. Add max homes setting when owner logs in. 3. Fix unit tests - they are probably broken 4. Add a conversion from player home locations to the island homes. Not sure what the best way to do this is. Use the owner's? 5. Localization of new strings
Closed
tastybento
added
the
Type: Enhancement
Closed
Conflicts: src/main/java/world/bentobox/bentobox/database/objects/Island.java
|
This is ready to go now. I haven't done the language translations, but apart from that it all seems to work. In terms of migration of homes, it's only done based on the island owner's homes. So, if non-owner team members had their own home locations, then they will lose them and they will be replaced by the owner's home locations, which are now the island home locations. They will be named simply 2,3,4,5, etc. |
Conflicts: src/test/java/world/bentobox/bentobox/managers/IslandsManagerTest.java
|
Unless there are any objections, I'm going to merge this into develop. We can improve it more over time. |
|
I agree with these changes. |
BONNe
approved these changes
Feb 28, 2021
|
Okay, I'm going to merge so that we can get some broader testing done before release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores home locations and max homes in the Island object and uses named homes instead of numbers. Adds commands
required to manage home names, specifically rename and delete. I did not add list as there is tab complete on island go, but it may be required.
To Do:
What is not done or supported (yet?):