Fixes crash loading addon with SNAPSHOT api-version #1684
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows providing -SNAPSHOT in `api-version` and warns in console, that some parts may not be implemented if the snapshot version is detected.
|
I thought this might happen when I saw you had the placeholder in addon.yml. However, I can see this being useful during development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows providing -SNAPSHOT in
api-versionand warns in console, that some parts may not be implemented if the snapshot version is detected.This comes from my laziness. I do not like to change addons.yml after implementing the new BentoBox API. So I just use
<bentobox.version>variable from the pom.xml file.This is just my laziness fixing. If not accepted, I can live with it.