Better island meta data api #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All classes now use the same interface and Optionals. Reduces code duplication and makes the API the same across the board.
tastybento
added
the
Type: Enhancement
Fixed since JavaDocs
BONNe
approved these changes
Jan 3, 2021
BONNe
approved these changes
Jan 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the previous MetaData API without breaking too much by using the MetaDataAble interface uniformly and making all the appropriate methods return optionals instead of nulls. Implementing classes need only implement the getter and setter for the metadata field. This approach removes a lot of code duplication and unifies the API between Island and User (and Player).