Adds saveObjectAsync with a CompletableFuture return for databases #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tastybento
added
Type: API
Poslovitch
added
the
Status: Need review
…m/BentoBoxWorld/BentoBox.git into completable_future_database_saves
Poslovitch
approved these changes
Apr 25, 2020
Poslovitch
added
Status: Done
Poslovitch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async saving to the database should return a completable future so that code can be written to run after the value has absolutely been saved to the database. This PR adds the method to the database classes to enable this. It retains but deprecates the original saveObject method. That method's return value was useless since we moved to async saving. It has to be kept though to support backwards runtime compatibility for addons that use saveObject.
I recommend all addons move to use saveObjectAsync after this PR is merged.