Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements placeholder permissions for addons #1305

Merged
merged 4 commits into from
Apr 25, 2020
Merged

Implements placeholder permissions for addons #1305

merged 4 commits into from
Apr 25, 2020

Conversation

tastybento
Copy link
Member

#1303

Needs test classes added

@tastybento tastybento marked this pull request as ready for review April 25, 2020 14:34
@Poslovitch Poslovitch self-requested a review April 25, 2020 15:40
@Poslovitch Poslovitch added Status: Need review Waiting for a review to be made on this Pull Request Type: Enhancement Improvement or modification which is usually a new feature. labels Apr 25, 2020
@Poslovitch Poslovitch added this to the 1.13.0 milestone Apr 25, 2020
@Poslovitch Poslovitch linked an issue Apr 25, 2020 that may be closed by this pull request
Addon separate permission enabling task. #1303
Closed
@Poslovitch Poslovitch added Type: API relating to the BentoBox API Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Need review Waiting for a review to be made on this Pull Request labels Apr 25, 2020
@Poslovitch Poslovitch changed the title Implements placeholder permissions Implements placeholder permissions for addons Apr 25, 2020
@Poslovitch Poslovitch merged commit 1f3a791 into develop Apr 25, 2020
@Poslovitch Poslovitch deleted the placeholder_permissions branch April 25, 2020 23:20
@Poslovitch Poslovitch mentioned this pull request Apr 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BONNe BONNe BONNe left review comments

@Poslovitch Poslovitch Poslovitch approved these changes

Assignees
No one assigned
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: API relating to the BentoBox API Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Addon separate permission enabling task.
3 participants
@tastybento @BONNe @Poslovitch