Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AdminSetSpawnPointCommand to change an island's spawn point #1295

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Add AdminSetSpawnPointCommand to change an island's spawn point #1295

merged 2 commits into from
Apr 24, 2020

Conversation

BONNe
Copy link
Member

@BONNe BONNe commented Apr 21, 2020

Fixes #937

This command allows changing spawn point for any island in each environment separately.
This is only the admin command.

@BONNe
Implement ability to change island spawn point.
e78c7ae 
Fixes BentoBoxWorld#937

This command allows to change spawn point for island in each environment.
@Poslovitch Poslovitch added Type: Enhancement Improvement or modification which is usually a new feature. Status: Need review Waiting for a review to be made on this Pull Request labels Apr 21, 2020
Poslovitch
Poslovitch requested changes Apr 23, 2020
View reviewed changes
Copy link
Member

@Poslovitch Poslovitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, but please apply the changes and make use of 4 spaces indents instead of tabs.

src/main/java/world/bentobox/bentobox/api/commands/admin/AdminSetSpawnPointCommand.java Outdated Show resolved Hide resolved
src/main/java/world/bentobox/bentobox/api/commands/admin/AdminSetSpawnPointCommand.java Outdated Show resolved Hide resolved
src/main/java/world/bentobox/bentobox/api/commands/admin/AdminSetSpawnPointCommand.java Outdated Show resolved Hide resolved
@Poslovitch Poslovitch added Status: Need revision Waiting for a revision to be made on this Pull Request and removed Status: Need review Waiting for a review to be made on this Pull Request labels Apr 23, 2020
@Poslovitch Poslovitch added this to the 1.13.0 milestone Apr 23, 2020
Poslovitch
Poslovitch approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@Poslovitch Poslovitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks!

@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Need revision Waiting for a revision to be made on this Pull Request labels Apr 24, 2020
@Poslovitch Poslovitch changed the title Implement ability to change island spawn point. Add AdminSetSpawnPointCommand to change an island's spawn point Apr 24, 2020
@Poslovitch Poslovitch merged commit 40240c7 into BentoBoxWorld:develop Apr 24, 2020
@BONNe BONNe deleted the spawn-point branch May 1, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Poslovitch Poslovitch Poslovitch approved these changes

@tastybento tastybento tastybento approved these changes

Assignees
No one assigned
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Setting island SpawnPoint
3 participants
@BONNe @tastybento @Poslovitch