Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds explicit permissions to team commands #1146

Merged
merged 2 commits into from
Jan 25, 2020
Merged

Adds explicit permissions to team commands #1146

merged 2 commits into from
Jan 25, 2020

Conversation

tastybento
Copy link
Member

#1144

Also fixes a bug where the untrust was using the coop perm.

I'm making this a PR because by requiring explicit perms it'll suddenly remove commands from players unless admins upgrade to the latest addons. So, I don't think it should be merged until we have the game mode addons updated with the latest permissions in their addon.yml's.

#1144

Also fixes a bug where the untrust was using the coop perm.
@@ -28,7 +28,7 @@ public IslandTeamUntrustCommand(CompositeCommand parentCommand) {

@Override
public void setup() {
setPermission("island.team.coop");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the bug.

Copy link
Member

@Poslovitch Poslovitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen that the gamemode addons were updated already. This PR is ready to be merged!

@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature. labels Jan 25, 2020
@Poslovitch Poslovitch added this to the 1.11.0 milestone Jan 25, 2020
@Poslovitch Poslovitch changed the title Adds explicit perms to team commands. Adds explicit permissions to team commands Jan 25, 2020
@Poslovitch Poslovitch merged commit 6e81af4 into develop Jan 25, 2020
@Poslovitch Poslovitch deleted the team_perms branch January 25, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants