Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings gui arrows #904

Closed
Nedjii opened this issue Aug 18, 2019 · 3 comments
Closed

Settings gui arrows #904

Nedjii opened this issue Aug 18, 2019 · 3 comments
Assignees
@tastybento
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Milestone
1.7.0

Comments

@Nedjii
Copy link

Nedjii commented Aug 18, 2019

Hello, i suggest to disable the "next-previous" button if there is no other page to show.
I also suggest to remove the command block when all flags related are hidden from players.
And i suggest to add something specific to set the title of the gui, actually it's the same option for the gui title and the item title "title:".
regards.
@tastybento
Copy link
Member

This is covered by #896

I don't see next/previous arrows showing. Can you share where you see them?

@tastybento tastybento self-assigned this Aug 18, 2019
@Nedjii
Copy link
Author

Nedjii commented Aug 18, 2019

Sure
2019-08-18_04 52 29
2019-08-18_04 52 27

@tastybento tastybento transferred this issue from BentoBoxWorld/BSkyBlock Aug 19, 2019
@tastybento tastybento added Status: In progress Working on the issue. Type: Bug labels Aug 19, 2019
@tastybento tastybento added this to the 1.7.0 milestone Aug 19, 2019
@tastybento tastybento changed the title Settings gui Settings gui arrows Aug 19, 2019
tastybento added a commit that referenced this issue Aug 19, 2019
@tastybento
Fixes next arrow showing when there is nothing on next page
b4d6628 
#904
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Aug 19, 2019
@tastybento
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
2 participants
@tastybento @Nedjii