Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island Members can't see who's banned on their island #891

Closed
OGreenC opened this issue Aug 12, 2019 · 2 comments
Closed

Island Members can't see who's banned on their island #891

OGreenC opened this issue Aug 12, 2019 · 2 comments
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Milestone

Comments

@OGreenC
Copy link

OGreenC commented Aug 12, 2019

Description

Describe the bug

Island members can't use the command /island banlist, to see who's banned on their island.
When they run the command, they are prompted with "You do not have an island!"

Steps to reproduce the behavior

Join another player's island, and run the command /is banlist

Screenshots and videos

I don't really think this picture is necessary, but here's a picture of my alt trying to run the command: (he's a member on my main's island).

Expected behavior

I would expect to be prompted with a list of the player's who's banned on the island that the player is a part.

Environment

Server

  • OS: Linux Centos
  • Java version: Java 8

Plugins

I'll post these if necessary - as of now, I don't really see the need to.

BentoBox setup

BentoBox and Addons
Running PAPER 1.13.2
Bentobox version 1.5.3

Loaded Game Worlds:
Skyblock (Skyblock)

Loaded Addons
Biomes 1.5.0.0
BSkyblock 1.5.0
Challenges 0.7.5
Level 1.5.0
Limits 0.2.3-SNAPSHOT
WelcomeWarps 1.5.0
Configuration
  • Database: MYSQL

Additional context

An idea would be, to only allow the island ranks who's access to the /is ban command, which is defined in the config, or the /island settings menu.
Alternatively, you could add this command as an entirely new setting in the config/island settings, so it can be adjusted this way by the server administrators.

@OGreenC OGreenC added Status: Pending Waiting for a developer to start working on this issue. Type: Bug labels Aug 12, 2019
@Poslovitch
Copy link
Member

Additional context

An idea would be, to only allow the island ranks who's access to the /is ban command, which is defined in the config, or the /island settings menu.
Alternatively, you could add this command as an entirely new setting in the config/island settings, so it can be adjusted this way by the server administrators.

I like this idea.

@tastybento tastybento self-assigned this Aug 13, 2019
@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. Status: In progress Working on the issue. and removed Status: Pending Waiting for a developer to start working on this issue. Status: Under investigation Investigating the interest and the feasability of the issue. labels Aug 13, 2019
@tastybento
Copy link
Member

Funnily enough, the command was originally written to be only available to a player with the ban command, i.e., the owner of the island. Now that others can ban, the command needs updating. In progress...

@tastybento tastybento added this to the 1.6.0 milestone Aug 13, 2019
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants