Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Spam in console after island reset #797

Closed
SkyDevil opened this issue Jun 28, 2019 · 1 comment
Closed

Error Spam in console after island reset #797

SkyDevil opened this issue Jun 28, 2019 · 1 comment
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Status: Important Must be done ASAP. Type: Bug
Milestone

Comments

@SkyDevil
Copy link

SkyDevil commented Jun 28, 2019

Description
A clear and concise description of what the bug is.
After Deletion of an island with the command /is reset
Console will start spamming

[18:00:38] [Server thread/WARN]: [BentoBox] Task #65 for BentoBox v1.6.0-SNAPSHOT-b1209 generated an exception
java.lang.NullPointerException: null
    at world.bentobox.bentobox.util.DeleteIslandChunks.regerateChunk(DeleteIslandChunks.java:84) ~[?:?]
    at world.bentobox.bentobox.util.DeleteIslandChunks.lambda$null$0(DeleteIslandChunks.java:53) ~[?:?]
    at java.util.Optional.ifPresent(Unknown Source) ~[?:1.8.0_211]
    at world.bentobox.bentobox.util.DeleteIslandChunks.lambda$new$1(DeleteIslandChunks.java:51) ~[?:?]
    at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftTask.run(CraftTask.java:81) ~[spigot.jar:git-Spigot-595711b-e8b39d4]
    at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:394) [spigot.jar:git-Spigot-595711b-e8b39d4]
    at net.minecraft.server.v1_14_R1.MinecraftServer.b(MinecraftServer.java:1011) [spigot.jar:git-Spigot-595711b-e8b39d4]
    at net.minecraft.server.v1_14_R1.DedicatedServer.b(DedicatedServer.java:396) [spigot.jar:git-Spigot-595711b-e8b39d4]
    at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:959) [spigot.jar:git-Spigot-595711b-e8b39d4]
    at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:804) [spigot.jar:git-Spigot-595711b-e8b39d4]
    at java.lang.Thread.run(Unknown Source) [?:1.8.0_211]

This will continue even after a server reset however deleting the database fixes it.
Server seems to run fine after and the new island is created after the reset command
Steps to reproduce the behavior:
1.create and island
2. type /is reset twice
3 check console

Expected behavior
No errors in console

Server Information:
2019-06-28_18 04 21

@tastybento tastybento self-assigned this Jun 28, 2019
@tastybento tastybento transferred this issue from BentoBoxWorld/BSkyBlock Jun 28, 2019
@tastybento tastybento added Status: Important Must be done ASAP. Status: In progress Working on the issue. Type: Bug labels Jun 28, 2019
@tastybento tastybento added this to the 1.6.0 milestone Jun 28, 2019
@tastybento
Copy link
Member

I was able to replicate this by setting the use-own-generator setting to true. This makes the default generator become null and so you see these errors. Generally, this setting must be false. @SkyDevil what does your config.yml for BSkyBlock say?

Either way, this raises the issue that chunk regeneration is not supported in 1.14 onwards. So, although we can still allow use-own-generator, there will be no regeneration of chunks for deleted islands. We can work around it for BentoBox add-ons because we have a defined interface, but not for 3rd party plugins like CleanRoomGenerator. That Bukkit method (regenerateChunk) has gone! I'll change the config file to reflect this change.

tastybento added a commit that referenced this issue Jun 29, 2019
Also handles situations where islands are pending deletion in the
database but the world they refer to has gone.

#797
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Status: Important Must be done ASAP. Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants