Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change super-flat cleaner to not use deprecated chunk regeneration method #720

Closed
tastybento opened this issue May 31, 2019 · 1 comment
Closed

Change super-flat cleaner to not use deprecated chunk regeneration method #720

tastybento opened this issue May 31, 2019 · 1 comment
Assignees
@tastybento
Labels
1.14 Related to 1.14+ Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Milestone
1.6.0

Comments

@tastybento
Copy link
Member

The Bukkit chunk regeneration method has completely gone in 1.14.x so the super-flat cleaner will have to use some other method to clean.
The same approach as island deletion is probably the best. It will call the generator from the GameModeAddon when there's a chunk to process and paste it accordingly.
@tastybento tastybento added the 1.14 Related to 1.14+ label May 31, 2019
@tastybento tastybento self-assigned this May 31, 2019
@tastybento tastybento added this to the 1.6.0 milestone May 31, 2019
@Poslovitch Poslovitch added the Type: Enhancement Improvement or modification which is usually a new feature. label Jun 1, 2019
@Poslovitch Poslovitch modified the milestones: 1.6.0, 1.5.1 Jun 9, 2019
@tastybento tastybento modified the milestones: 1.5.1, 1.5.2 Jun 10, 2019
@Poslovitch Poslovitch modified the milestones: 1.5.2, 1.5.3 Jun 16, 2019
@Poslovitch
Copy link
Member

Postponing this to 1.6.0.

@Poslovitch Poslovitch modified the milestones: 1.5.3, 1.6.0 Jun 21, 2019
@tastybento tastybento added the Status: In progress Working on the issue. label Jul 5, 2019
tastybento added a commit that referenced this issue Jul 5, 2019
@tastybento
Changes clean super flat to use manual chunk gen
cb8b323 
#720
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
1.14 Related to 1.14+ Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@tastybento @Poslovitch