Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission "bskyblock.island.range.<number>" does not increase island range. #664

Closed
MorkaZ opened this issue May 6, 2019 · 10 comments
Closed
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Status: Important Must be done ASAP. Type: Bug
Milestone

Comments

@MorkaZ
Copy link

MorkaZ commented May 6, 2019

When I add permission "bskyblock.island.range.100" to VIP group and player that is in this group with this permission will create island then he will have default island range instead of range from this permission.

Here is quote from configuration:

Default protection range radius in blocks. Cannot be larger than distance.
Admins can change protection sizes for players individually using /bsbadmin range set
or set this permission: bskyblock.island.range.number

I have everytime to set range of my players island manually using command /bsb range set player 100
Please, fix it :(

@BONNe
Copy link
Member

BONNe commented May 6, 2019

Pleas... add /bentobox v output
Also... does island distance in config is larger then 100?

@MorkaZ
Copy link
Author

MorkaZ commented May 6, 2019

Here are my settings:

distance-between-islands: 108
protection-range: 50

My /bentobox v output:

@Poslovitch Poslovitch transferred this issue from BentoBoxWorld/BSkyBlock May 6, 2019
@Poslovitch
Copy link
Member

What permissions plugin are you using?
What range gets displayed if you run /bsbadmin info playername?

@MorkaZ
Copy link
Author

MorkaZ commented May 6, 2019

MoxPerms (my own). Tried with pex with same result.
"/bsbadmin info player" returns 50

@MorkaZ
Copy link
Author

MorkaZ commented May 6, 2019

This does not make any sense. If it is set then this value should stay forever. Also comments in config of Bskyblock informs:

Admins can change protection sizes for players individually using /bsbadmin range set
OR set this permission: bskyblock.island.range.number

@Poslovitch
Copy link
Member

Commands get overridden by permissions. That's an issue we were already having on ASkyBlock.

@MorkaZ
Copy link
Author

MorkaZ commented May 7, 2019

I have created simple script that will set range of player's island if they type command "/is upgrade".

If someone needs it working then you should use this script. It will also fix protection range of actual islands.

I will add it today on my github and link to it here.

EDIT: Added it below. Sorry for late update.

@Poslovitch Poslovitch added Status: Under investigation Investigating the interest and the feasability of the issue. Type: Bug Status: Need answer Waiting for more information to be provided by the issue's author. labels May 26, 2019
@Poslovitch
Copy link
Member

Any info about that skript of yours @MorkaZ ?

@MorkaZ
Copy link
Author

MorkaZ commented May 27, 2019

Oh, I forgot. My bad. Here it is:

IslandUpgrade.txt

Just change .txt to .sk (couldn't update in that format) and edit it for your own server (change permissions, messages, prefix, range in bsb command).

@bepiis
Copy link

bepiis commented Jun 5, 2019

For the record, I use this permission for ranks on my server and it works just fine. Im on paper-625 and I use LuckPerms for permissions

@tastybento tastybento added this to the 1.6.0 milestone Aug 8, 2019
@tastybento tastybento removed the Status: Need answer Waiting for more information to be provided by the issue's author. label Aug 8, 2019
@tastybento tastybento self-assigned this Aug 8, 2019
@tastybento tastybento added Status: Accepted Status: Important Must be done ASAP. Status: In progress Working on the issue. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Aug 10, 2019
tastybento added a commit that referenced this issue Aug 10, 2019
#664

Added test class for NewIsland class
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Accepted Status: In progress Working on the issue. labels Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Status: Important Must be done ASAP. Type: Bug
Projects
None yet
Development

No branches or pull requests

5 participants