Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the generic "Success!" with more specific messages at some instances #630

Closed
22 tasks done
Poslovitch opened this issue Apr 10, 2019 · 3 comments
Closed
22 tasks done

Replace the generic "Success!" with more specific messages at some instances #630

Poslovitch opened this issue Apr 10, 2019 · 3 comments
Assignees
@Poslovitch
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Milestone
1.6.0

Comments

@Poslovitch
Copy link
Member

Poslovitch commented Apr 10, 2019 •
edited
Loading

Description

Is your feature request related to a problem?

Suggested by @DDuart on Discord.

general.success looks weird in some places.

Describe the solution you'd like us to implement.

Create new messages, for example Player has been unbaned., The player was kicked from the island., The player was kicked from the team..

There are a few places where we can effectively replace the generic "success" message with more specific ones. Such places need to be investigated first, but are in all likelihood commands' operation feedback.

Describe alternatives you've considered.

None.

Additional context

None.

Progress

Island commands

  • ban
  • unban
  • team kick
  • team leave
  • team coop
  • team uncoop
  • team trust
  • team untrust
  • expel

Admin commands

  • emptytrash
  • register
  • unregister
  • resetflags
  • delete
  • switchto
  • setspawn
  • team kick
  • team add
  • team setowner
  • team disband
  • deaths reset
  • deaths set
@Poslovitch Poslovitch added Type: Enhancement Improvement or modification which is usually a new feature. Status: Accepted labels Apr 10, 2019
@Poslovitch Poslovitch added this to the 1.5.0 milestone Apr 10, 2019
@Poslovitch Poslovitch self-assigned this Apr 11, 2019
@Poslovitch Poslovitch added Status: In progress Working on the issue. and removed Status: Accepted labels Apr 17, 2019
Poslovitch added a commit that referenced this issue Apr 27, 2019
@Poslovitch
Added better success feedback messages for IslandBanCommand and Islan…
8ba0ebd 
…dUnbanCommand

#630
Poslovitch added a commit that referenced this issue Apr 28, 2019
@Poslovitch
Added better success messages for admin deaths and island team kick c…
3ef6529 
…ommands

#630
Poslovitch added a commit that referenced this issue Apr 28, 2019
@Poslovitch
Added better success message to AdminTeamKickCommand
722f136 
#630
Poslovitch added a commit that referenced this issue Apr 28, 2019
@Poslovitch
Added better success messages to admin team commands
6100420 
#630
@Poslovitch
Copy link
Member Author

This has been partially done in 1.5.0. Further work on this issue will be done in 1.6.0 or later.

@Poslovitch Poslovitch modified the milestones: 1.5.0, 1.6.0 Jun 5, 2019
@BONNe
Copy link
Member

BONNe commented Jun 5, 2019

:(

Poslovitch added a commit that referenced this issue Jun 29, 2019
@Poslovitch
Added better success message to island team commands
9fe43fe 
#630
Poslovitch added a commit that referenced this issue Jun 29, 2019
@Poslovitch
Added better success message to island expel command
c09ff50 
#630
Poslovitch added a commit that referenced this issue Jun 30, 2019
@Poslovitch
Improved success messages for admin commands and fixed failing tests
64d89f9 
#630
@Poslovitch
Copy link
Member Author

Finally done!

@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Poslovitch Poslovitch

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@BONNe @Poslovitch