Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item frame island setting #391

Closed
TheWranger opened this issue Dec 16, 2018 · 4 comments
Closed

Item frame island setting #391

TheWranger opened this issue Dec 16, 2018 · 4 comments
Assignees
Labels
Type: Enhancement Improvement or modification which is usually a new feature.
Milestone

Comments

@TheWranger
Copy link

Is your feature request related to a problem? Please describe.
There's currently no setting to control who can interact with item frames.

Describe the solution you'd like
An island setting that manages who can interact with item frames (includes rotating and changing the contained item).

Describe alternatives you've considered
No alternatives.

@Poslovitch Poslovitch added the Type: Enhancement Improvement or modification which is usually a new feature. label Dec 16, 2018
@Poslovitch Poslovitch self-assigned this Dec 16, 2018
@Poslovitch Poslovitch added this to the Alpha 13 milestone Dec 16, 2018
@Poslovitch Poslovitch removed their assignment Dec 16, 2018
@Poslovitch
Copy link
Member

Might be good to make it include paintings, isn't it?

@tastybento Have a look at these events: https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/hanging/package-summary.html

@TheWranger
Copy link
Author

TheWranger commented Dec 16, 2018

I don't think painting have interactions that need to be managed by a setting

@tastybento tastybento self-assigned this Dec 21, 2018
@tastybento
Copy link
Member

I'll work on this over the holiday.

@TheWranger
Copy link
Author

TheWranger commented Dec 22, 2018

I don't think it should affect placing of item frames and paintings as I think those are fine being handled by block placing. Just the interactions with item frames.

@Poslovitch Poslovitch modified the milestones: Alpha 13, Before 2019 Dec 23, 2018
Poslovitch added a commit that referenced this issue Jan 2, 2019
@Poslovitch Poslovitch assigned Poslovitch and unassigned tastybento Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants