Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework World management to allow for multiple schematics per gamemode #378

Closed
Poslovitch opened this issue Dec 14, 2018 · 1 comment
Closed

Rework World management to allow for multiple schematics per gamemode #378

Poslovitch opened this issue Dec 14, 2018 · 1 comment
Assignees
@Poslovitch
Labels
Status: Declined Feature request or tweak that has been declined due to its difficulty or poor feasibility/interest. Type: Enhancement Improvement or modification which is usually a new feature.

Comments

@Poslovitch
Copy link
Member

Multiple schematics are currently not supported.

Describe the solution you'd like
Allow users to add multiple schematics to a gamemode.
Relates to #104 and #207.

Additionnal context
It will need the "World management rework" in order to be easily implemented.
@Poslovitch Poslovitch added the Type: Enhancement Improvement or modification which is usually a new feature. label Dec 14, 2018
@Poslovitch Poslovitch self-assigned this Dec 14, 2018
@Poslovitch Poslovitch pinned this issue Dec 14, 2018
This was referenced Dec 14, 2018
Closed
Closed
Closed
@Poslovitch Poslovitch changed the title Multiple schematics per gamemode Rework World management to allow for multiple schematics per gamemode Dec 14, 2018
This was referenced Dec 22, 2018
Closed
Closed
tastybento added a commit that referenced this issue Dec 24, 2018
@tastybento
Uses current API to enable multiple schems.
0adc2e3 
This will load all schems in an add-on's schem folder if it exists and
associate them with this world set (overworld, nether and end). Schems
can be named anything, but the partner nether or end worlds must be
pre-fixed with "nether-" or "end-" in the filename.
Additional schems can be added by the admin into the schem folder, or
they can be stored in the jar file of the add-on. Both are supported.

No changes are required to current add-ons. I.e., there is no API
breakage here, but I would like to rename the SchemsManager method
loadIslands(World world) to be loadSchems(World world) in the future.

Related issues/PR:
#104
#207
#378
#408
@tastybento tastybento mentioned this issue Dec 24, 2018
Merged
@Poslovitch
Copy link
Member Author

Multiple schems got implemented in #412. Closing.

@Poslovitch Poslovitch unpinned this issue Dec 24, 2018
@Poslovitch Poslovitch added the Status: Declined Feature request or tweak that has been declined due to its difficulty or poor feasibility/interest. label Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Poslovitch Poslovitch

Labels
Status: Declined Feature request or tweak that has been declined due to its difficulty or poor feasibility/interest. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Poslovitch