Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to give single additional island resets #353

Closed
TheWranger opened this issue Nov 25, 2018 · 6 comments
Closed

Ability to give single additional island resets #353

TheWranger opened this issue Nov 25, 2018 · 6 comments
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.

Comments

@TheWranger
Copy link

TheWranger commented Nov 25, 2018

Is your feature request related to a problem? Please describe.
It currently isn't possible to sell additional island resets in server shops without resetting their island reset count. This is inconvenient and is kinda limiting.

Describe the solution you'd like
A command to increase the amount of island resets a specific player is allowed by a certain amount, or to decrease them by a certain amount.

Describe alternatives you've considered
A command to give a player an additional island reset and a command to take an island reset away
Permissions that can be used to set how many island resets a player has.

Additional context
Applies to both BSkyblock and AcidIsland so wasn't sure where to put this. Hopefully this is the right spot.

@Poslovitch Poslovitch added the Type: Enhancement Improvement or modification which is usually a new feature. label Dec 7, 2018
@Poslovitch Poslovitch self-assigned this Dec 7, 2018
@Poslovitch Poslovitch added this to the Alpha 11 milestone Dec 7, 2018
@Poslovitch Poslovitch modified the milestones: Alpha 11, Alpha 12 Dec 9, 2018
@Poslovitch Poslovitch added this to the Before 2019 milestone Dec 24, 2018
@Poslovitch
Copy link
Member

There's no way to increase or decrease a player's island reset limit (or maybe it can be done using permissions, I don't know). However, unlike ASkyBlock, we do not keep track of how many resets are left for the player. We rather keep track of how many resets this player did. Therefore, such commands (which I'm working on) will only be able to interact with this value. Reset to 0, set to an arbitrary value, or increase/decrease the value by an amount - yet, the final value must be above or equal to 0.

I've put resets commands under their own node in an upcoming commit, however I'd like to have your feedback about what I just said above. @TheWranger Would that be fine, or should we consider doing something else?

Poslovitch added a commit that referenced this issue Dec 29, 2018
Preparing #353.

AdminClearresetsallCommand is deprecated with no current alternative right now.
@TheWranger
Copy link
Author

It would be better if the end value could go below 0 but it would probably be easily to workaround that.
I think that should be fine.

@Poslovitch
Copy link
Member

@TheWranger Is there still a need for this specific request ?

@Poslovitch
Copy link
Member

Closing.

@Poslovitch Poslovitch added the Status: Done This issue has been completed or answered. This pull request has been merged. label May 14, 2019
@Poslovitch Poslovitch removed this from the Before 2019 milestone May 14, 2019
@TheWranger
Copy link
Author

TheWranger commented May 25, 2019

Sorry, I was busy with other things I wasn't able to keep up with Bentobox's development. But yea, this is something that I think should be added (and that my players want). Did this end up getting added @Poslovitch?

@Poslovitch
Copy link
Member

@TheWranger

There's no way to increase or decrease a player's island reset limit (or maybe it can be done using permissions, I don't know). However, unlike ASkyBlock, we do not keep track of how many resets are left for the player. We rather keep track of how many resets this player did. Therefore, such commands (which I'm working on) will only be able to interact with this value. Reset to 0, set to an arbitrary value, or increase/decrease the value by an amount - yet, the final value must be above or equal to 0.

I've put resets commands under their own node in an upcoming commit, however I'd like to have your feedback about what I just said above. @TheWranger Would that be fine, or should we consider doing something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants