Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coop not removing after logout #335

Closed
Kryniowesegryderiusz opened this issue Nov 8, 2018 · 14 comments
Closed

Coop not removing after logout #335

Kryniowesegryderiusz opened this issue Nov 8, 2018 · 14 comments
Assignees
Milestone

Comments

@Kryniowesegryderiusz
Copy link

Description
Coop is not removed from cooped player after logout (does not work, when leader or member or even cooped player loggs out)

Server Information:

[Please complete the following information:]

  • Database being used (Flat file, MySQL, Mongo): MySQL
  • OS: Ubuntu
  • Java Version: 8
  • BentoBox version: 0.14.0
  • Addons installed?
BSkyBLock 0.5.0
WelcomeWarps 0.1.0
Level 0.1.0
Challenges 0.0.3
@Poslovitch Poslovitch added Status: Under investigation Investigating the interest and the feasability of the issue. Type: Bug and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Nov 9, 2018
@Poslovitch
Copy link
Member

Can confirm the bug is occuring on the latest version, as I cannot find any occurences of "coop rank removal" in the code: https://github.com/BentoBoxWorld/bentobox/search?l=Java&q=coop.

@Poslovitch Poslovitch self-assigned this Nov 11, 2018
@Poslovitch
Copy link
Member

@tastybento I will need help on this one, I don't know how I could get the islands the "target" is cooped on. Do you have any ideas on that?

@tastybento
Copy link
Member

I’ll look at this. I remember now that this feature was not finished after I added the ranks. Coop is currently not removed when the inviter logs out.

@Poslovitch
Copy link
Member

@tastybento I'm assigning you to this issue.

@Poslovitch Poslovitch assigned tastybento and unassigned Poslovitch Nov 17, 2018
@tastybento
Copy link
Member

Yep. I’m on holiday this week so I can work on some of these!

@tastybento
Copy link
Member

So, I've added the functionality to remove coops when the cooped player logs out and also remove all coops if the server is shutdown. I think that should be sufficient. If the inviter wants the player to be un-cooped, they can use the command to do that. Does that work or did I miss something?

@Kryniowesegryderiusz
Copy link
Author

Maybe also add someting like, if player who added visitor to coop loggs out it removes from coops. Ex. when someone lost connection, and cant uncoop. Like in askyblock

@tastybento
Copy link
Member

Yeah, I understand but I purposely didn't add that because it requires another database to store a history of who invited who. Let me think about that one.

@Kryniowesegryderiusz
Copy link
Author

So maybe just if all usrs added to island loggs off?

@Poslovitch
Copy link
Member

Might be a bit "too much", I think...

@tastybento
Copy link
Member

@Kryniowesegryderiusz That may be possible. If the last true member or above in rank logs off then all coops ranks could be cleared.

@Kryniowesegryderiusz
Copy link
Author

That would be enough I think

@tastybento
Copy link
Member

I'm going to work on this now...

@Poslovitch Poslovitch added this to the Alpha 12 milestone Dec 10, 2018
@tastybento
Copy link
Member

Done in commit 3dd7126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants