-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coop not removing after logout #335
Comments
Can confirm the bug is occuring on the latest version, as I cannot find any occurences of "coop rank removal" in the code: https://github.com/BentoBoxWorld/bentobox/search?l=Java&q=coop. |
@tastybento I will need help on this one, I don't know how I could get the islands the "target" is cooped on. Do you have any ideas on that? |
I’ll look at this. I remember now that this feature was not finished after I added the ranks. Coop is currently not removed when the inviter logs out. |
@tastybento I'm assigning you to this issue. |
Yep. I’m on holiday this week so I can work on some of these! |
So, I've added the functionality to remove coops when the cooped player logs out and also remove all coops if the server is shutdown. I think that should be sufficient. If the inviter wants the player to be un-cooped, they can use the command to do that. Does that work or did I miss something? |
Maybe also add someting like, if player who added visitor to coop loggs out it removes from coops. Ex. when someone lost connection, and cant uncoop. Like in askyblock |
Yeah, I understand but I purposely didn't add that because it requires another database to store a history of who invited who. Let me think about that one. |
So maybe just if all usrs added to island loggs off? |
Might be a bit "too much", I think... |
@Kryniowesegryderiusz That may be possible. If the last true member or above in rank logs off then all coops ranks could be cleared. |
That would be enough I think |
I'm going to work on this now... |
Done in commit 3dd7126 |
Description
Coop is not removed from cooped player after logout (does not work, when leader or member or even cooped player loggs out)
Server Information:
[Please complete the following information:]
The text was updated successfully, but these errors were encountered: