Max homes limit for players is the set limit minus 1

[SenorFlamingo]

Expected behavior

Max homes of a player respects the configured limit with the ingame command

Observed/Actual behavior

When setting a home that's one less than the limit, you will get a message that you've reached the limit with the correct limit amount, even though you've only set one home less.

Steps/models to reproduce

• use /bsbadmin setmaxhomes [playername] 4
• set three homes with player
• try to make a fourth one with the error appearing

Note: if this doesn't reproduce the bug, it might also be that I've repositioned existing homes before the limit was reached.

BentoBox version

Running PAPER 1.21.1.
(1.21.1-120-57c75a4 (MC: 1.21.1))
BentoBox version: 2.6.0
Database: JSON
Loaded Game Worlds:
skyblock_world (SkyBlock): Overworld, Nether, The End
Loaded Addons:
Bank 1.8.0 (ENABLED)
Biomes 2.2.0-SNAPSHOT-b258 (ENABLED)
Border 4.3.0 (ENABLED)
BSkyBlock 1.18.1 (ENABLED)
Challenges 1.3.1 (ENABLED)
Chat 1.2.0 (ENABLED)
ControlPanel 1.13.1 (ENABLED)
DimensionalTrees 1.7.0 (ENABLED)
ExtraMobs 1.13 (ENABLED)
IslandFly 1.13.0 (ENABLED)
Level 2.16.1 (ENABLED)
Likes 2.4.0 (ENABLED)
Limits 1.25.0 (ENABLED)
MagicCobblestoneGenerator 2.5.2-SNAPSHOT-b272 (ENABLED)

Plugin list

Server Plugins (87):
Paper Plugins:
 - AutoPickup2, BetterChestShops, Minepacks, RoseStacker, SignedVelocity, UltimateJQMessages, UltimateMobCoins, UltimateTags, UltimateWands
Bukkit Plugins:
 - ajLeaderboards, AntiAFKPlus, AreaShop, ArmorStandEditor, BentoBox, BentoBox-Bank, BentoBox-Biomes, BentoBox-BSkyBlock, BentoBox-Challenges, BentoBox-IslandFly
 BentoBox-Level, BentoBox-Likes, BentoBox-Limits, BentoBox-MagicCobblestoneGenerator, BetonQuest, BetterBoard, BottledExp, ChestShop, ChestShopNotifier, Citizens
 CleanroomGenerator, CMI, CMILib, *ConditionalPerms, CraftingStore, DecentHolograms, DeluxeCoinflip, DeluxeCombat, Duels, eco
 EcoEnchants, EffectLib, EntityDetection, Fadah, FastAsyncWorldEdit, FreedomChat, HeadDatabase, Hyperverse, InteractiveBoard, libreforge
 LibsDisguises, *LibsDisguiseWGFlags, LimitCrafting, LogBlock, cMMO, MobArena, MobFarmManager, MythicMobs, NametagEdit, NBTAPI
 NetworkManager, packetevents, Parkour, ParticlesMenu, PL-Hide, PlaceholderAPI, PlayerParticles, PlayerPoints, Polymart, PremiumVanish
 ProtocolLib, Shopkeepers, SimplePets, SpecializedCrates, *TCRestart, TNTRun_reloaded, TradeSystem, TryMe, UltimateMenus, UltimateShoutPro
 UpgradeableHoppers, Vault, ViaBackwards, ViaVersion, VoidGen, VotingPlugin, WGEF-Reborn, WorldGuard

Other

No response

[tastybento]

Thanks. This was because the default unnamed home (the one you go to if you do /is) was being counted. THis change will enable players to set one named home in addition to their default home. Not a bad thing.