Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better success messages for IslandSetnameCommand and IslandResetnameCommand #1164

Closed
Poslovitch opened this issue Feb 1, 2020 · 0 comments
Closed

Add better success messages for IslandSetnameCommand and IslandResetnameCommand #1164

Poslovitch opened this issue Feb 1, 2020 · 0 comments
Assignees
@Poslovitch
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Milestone
1.11.1

Comments

@Poslovitch
Copy link
Member

Description

Is your feature request related to a problem?

"Success!" feels like a placeholder message.

Describe the solution you'd like us to implement.

Success messages for these commands coulf be enhanced by telling the player the name he chose.

Describe alternatives you've considered.

None.

Additional context

None.
@Poslovitch Poslovitch added Type: Enhancement Improvement or modification which is usually a new feature. Status: Pending Waiting for a developer to start working on this issue. labels Feb 1, 2020
@Poslovitch Poslovitch added this to the 1.11.1 milestone Feb 1, 2020
@Poslovitch Poslovitch self-assigned this Feb 1, 2020
@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Pending Waiting for a developer to start working on this issue. labels Feb 1, 2020
Poslovitch added a commit that referenced this issue Feb 1, 2020
@Poslovitch
Added specific success messages for Island(Re)SetnameCommand
6c5df58 
Implements #1164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Poslovitch Poslovitch

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Milestone
1.11.1
Development

No branches or pull requests
1 participant
@Poslovitch