Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nether portals on islands to work with island nether disabled #1101

Open
Disorbs opened this issue Jan 2, 2020 · 10 comments
Open

Allow nether portals on islands to work with island nether disabled #1101

Disorbs opened this issue Jan 2, 2020 · 10 comments
Assignees
Labels
Type: Enhancement Improvement or modification which is usually a new feature.

Comments

@Disorbs
Copy link

Disorbs commented Jan 2, 2020

Description

So on 1.8.0 of bento box with Bskyblock i had the bskyblock nether disabled and when then create a normal nether world and link it with Multiverse nether portals but after upgrading to 1.9.0+ of bentobox that is no longer possible as it seems it was made to disable portals if you have island nether disabled and was wondering if you can bring this back to allow normal nether worlds to be linked with portals on bskyblock.

Is your feature request related to a problem?

Yes i believe you guys made it so that if on 1.9.0+ we disable the nether island for bskyblock it disables nether portals in general which broke my way to use the normal nether.

Describe the solution you'd like us to implement.

Make portals work if you have island nether disabled on bskyblock so we can link it to normal nether worlds.

Describe alternatives you've considered.

maybe a addon to fix this would also be nice if its not something worth adding to bentobox.

@Poslovitch Poslovitch added Status: Pending Waiting for a developer to start working on this issue. Type: Enhancement Improvement or modification which is usually a new feature. labels Jan 4, 2020
@Poslovitch Poslovitch added this to the 1.11.1 milestone Jan 27, 2020
@tastybento tastybento self-assigned this Feb 7, 2020
@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. Status: In progress Working on the issue. and removed Status: Pending Waiting for a developer to start working on this issue. labels Feb 7, 2020
@tastybento
Copy link
Member

This is due to changes made to fix #1036. Since 1.14.4 it became necessary to cancel the portal event in the overworld otherwise the default behavior of the server was to teleport players to the default nether world.

Looking at MV code they set their listener at NORMAL priority. Changing ours to HIGH should give them first shot at teleporting.

@tastybento
Copy link
Member

Please try the latest build (once it finishes building) and see if you can use MV Nether Portals okay.

@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Feb 7, 2020
@Poslovitch Poslovitch added Status: Monitoring Monitoring the issue to see if it is fixed or if more information becomes available and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Feb 8, 2020
@Disorbs
Copy link
Author

Disorbs commented Apr 30, 2020

I still have this issue on the latest bentobox 1.12.0 (on 1.15.2 not sure what version to use)
and bskyblock 1.12.0 and nothing happens when i sit in the portal and i already linked bskyblock_world > island_nether_world which should be a normal nether world.

@tastybento tastybento reopened this May 1, 2020
@tastybento
Copy link
Member

I had a look through MV code and they don't actually cancel the event or teleport you, so changing the event priority doesn't have any affect.

The problem is that if an admin configures BSkyBlock to have no nether and a player enters a nether portal, then the default behavior of the server is to teleport them to the regular nether. This is not desirable. They should just sit there. So since 1.14, we have to cancel the event and that's what happens.

The only way to enable MV NetherPortals to link is to have some kind of switch in a config.

By the way, I tried linking nether worlds to BSkyBlock's over world and I can teleport into them. However, if I link back from the nether world to BSkyBlock, it'll make random portals in other people's island space, depending on where you put the portal in the nether. How do you handle that?

@tastybento tastybento removed Status: Done This issue has been completed or answered. This pull request has been merged. Status: Monitoring Monitoring the issue to see if it is fixed or if more information becomes available labels May 1, 2020
@tastybento tastybento removed this from the 1.11.1 milestone May 1, 2020
@Poslovitch Poslovitch added the Status: Pending Waiting for a developer to start working on this issue. label May 1, 2020
@Disorbs
Copy link
Author

Disorbs commented May 2, 2020

well i handle by making no nether portal form on the nether world so they dont create portals from nether world to bskyblock.

/mv modify set portalform none

@tastybento
Copy link
Member

Nice. Okay, well this will have to be a config setting because there isn't a way to stop the default teleport otherwise.

@tastybento tastybento removed the Status: Pending Waiting for a developer to start working on this issue. label May 2, 2020
@PhobosKOM
Copy link

This issue is closely related to mine. It would be helpful to have the option to disable the enhanced portal mechanics and allow transport to the "normal" nether and end

In my case I have a datapack to handle the terrain generation and I don't intend to use most of the island management options. I basically just need the ability to create new islands as needed. The goal is to have a vanilla like experience that happens to be in a void world.

Three points were brought up in discord as to why the enhanced portal mechanics are needed:
(a) for fairness - to avoid someone getting just a lake of lava and nothing,
(b) control - the admin can stick the spawn point somewhere interesting
(c) to avoid nether portals appearing on other player's islands when the players make a portal in the nether.

Our community is small and tight knit, and we generally cooperate with eachother.
We are also going to have very large and spread out islands, making things more fair as we should all end up with comparable access to resources.
We are not concerned with an interesting placement as the idea is to branch out and explore.
The odds of accidentally landing on someone else's island is small given that we will be thousands of meters apart. We would actually want to create a nether hub to allow for things such as transporting villagers and livestock.

@BONNe
Copy link
Member

BONNe commented Nov 29, 2024

@PhobosKOM if you disable nether and end islands, it generates normal worlds, and teleportation via portals should work properly.
Unless there is another plugin (like multiverse) that tries to overwrite what BentoBox is doing.

@tastybento
Copy link
Member

I think he wants portals to go to spots in the nether based on the over world coordinates. It'll mean endless an obsidian - just portal to nether, mine it from created portal, do /is and repeat. But if it's marked as zero value it may be okay.

@PhobosKOM
Copy link

I am looking for a way for the vanilla portal mechanics to work, meaning a portal at 80,80 would connect to 10,10 in the nether. When I set nether: generate: false the portal simply did nothing, even if create-and-link-portals is set to true. I can see the use case for denying the nether completely, but maybe if generate nether is set to false but link portals is set to true it would not generate the BentoBox nether but still link to the vanilla nether. That specific implementation is just an idea, I'd be happy with any flag that works.

Regarding obsidian farming the datapack we are using to create the void will generate vanilla structures like ruined portals, so obsidian would be obtainable that way anyway.

Thanks for even considering this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement or modification which is usually a new feature.
Projects
Development

No branches or pull requests

5 participants