Permissions can extend island range beyond island distance

[tastybento]

Description

Describe the bug

Players with a permission of acidisland.island.range.<number> where is greater than the island distance will get an island protection zone that big. It should not be more than the max island distance.

Steps to reproduce the behavior

1. Give player permission acidisland.island.range.<number> where number is greater than the island distance.
2. Player should log out and log in.
3. Do /acid info (player) and see the large range

Expected behavior

It should not be more than the max island distance.

Environment

[02:36:57 INFO]: Running PAPER 1.14.4.
[02:36:57 INFO]: BentoBox version: 1.8.0
[02:36:57 INFO]: Database: JSON2MYSQL
[02:36:57 INFO]: Loaded Game Worlds:
[02:36:57 INFO]: acidisland_world (AcidIsland): Overworld, Nether, End
[02:36:57 INFO]: bskyblock_world (BSkyBlock): Overworld, Nether, End
[02:36:57 INFO]: Loaded Addons:
[02:36:57 INFO]: AcidIsland 1.8.0 (ENABLED)
[02:36:57 INFO]: BentoBox-InvSwitcher 0.0.4 (ENABLED)
[02:36:57 INFO]: BSkyBlock 1.8.0 (ENABLED)
[02:36:57 INFO]: Level 1.8.0 (ENABLED)
[02:36:57 INFO]: WelcomeWarps 1.6.0-SNAPSHOT-b158 (ENABLED)

[tastybento]

Method to calculate permission values was incorrect as well if the default setting was greater than the allocated perm. i.e., it was not possible to give players a perm value of less than the default. This will be fixed.

[BONNe]

Hmm, wasn't it intended to prevent permission to be smaller then default value?
As in wiki it is written so.
And it makes a sense....

[tastybento]

I am going off the JavaDocs, which has always said "defaultValue the default value; the result may be higher or lower than this", except it was never lower before I fixed the bug:

    /**
     * Get the maximum value of a numerical permission setting.
     * If a player is given an explicit negative number then this is treated as "unlimited" and returned immediately.
     * @param permissionPrefix the start of the perm, e.g., {@code plugin.mypermission}
     * @param defaultValue the default value; the result may be higher or lower than this
     * @return max value
     */

Here's how it should and now does work:

1. Default value is used if player has no overriding permission.
2. Default value is used if player has a * permission.
3. If player has a permission, it overrides the default value
4. If player has multiple permissions of the same kind but different values, the maximum value is returned.

Can you point me to the Wiki so I can clarify? I couldn't find the reference.