Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appearing in the void when going to island since 1.8 #1017

Closed
YellowZaki opened this issue Oct 29, 2019 · 8 comments
Closed

Appearing in the void when going to island since 1.8 #1017

YellowZaki opened this issue Oct 29, 2019 · 8 comments
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug

Comments

@YellowZaki
Copy link
Contributor

YellowZaki commented Oct 29, 2019

Since BentoBox 1.8, I'm receiving reports of players appearing on the void sometimes when doing /is.

Today, Player A banned Player B from their island. Player B appeared in the void, specifically where Player A's island end in a side.

I haven't found any console error.
If you have encountered this error on you server, comment please.

@tastybento
Copy link
Member

Today, Player A banned Player B from their island. Player B appeared in the void, specifically where Player A's island end in a side.

Can you explain "end in a side" please? I don't understand.

@tastybento
Copy link
Member

It sounds like when the ban happened, Player B should have been teleported to their home. But wasn't...

@tastybento tastybento added Status: Monitoring Monitoring the issue to see if it is fixed or if more information becomes available Status: Under investigation Investigating the interest and the feasability of the issue. Type: Bug labels Oct 30, 2019
@tastybento tastybento self-assigned this Oct 30, 2019
@YellowZaki
Copy link
Contributor Author

YellowZaki commented Oct 30, 2019

This is an island:

|.................... |
|.....................| <----Here is the end in a side
|.....................|

@tastybento
Copy link
Member

Does player B have an island in that world or on a team? If Player B has an island and is banned, then they will be immediately teleported to their own home location on their island. If he doesn't then the plugin will try to do the following as soon as he moves:

  1. Teleport to island home (which will fail)
  2. Teleport to island spawn (as determined by admin setspawn command)
  3. Teleport to the world's spawn location - which may be the void.

If the 3rd one happens, then you should be able to see this in the logs:

Could not teleport 'Player B' back to his island or the spawn.
Please consider setting a spawn for this world using the admin setspawn command.

Do you see any of that in your logs?

@YellowZaki
Copy link
Contributor Author

YellowZaki commented Nov 3, 2019

I see 3rd

[18:34:32] [Server thread/INFO]: [BentoBox] Could not teleport 'hackveneno35' back to his island or the spawn.
[18:34:32] [Server thread/INFO]: [BentoBox] Please consider setting a spawn for this world using the admin setspawn command.

He has island home.

Some interesting things:

  • When a player dies, they are teleported to their home sucessfully.
  • When doing /is ban , the player is teleported to void after 2-3 seconds, not inmediatly.
  • RespawnListener is using getSafeHomeLocation() while ban command is using getIslands().homeTeleport() (which uses SafeSpotTeleport)
  • Since 1.8, going to the end island is lasting more than normal (it also uses SafeSpotTeleport )

@tastybento
Copy link
Member

I found a bug for the couldn't teleport issue. It only worked if the player is a team leader, not a team member.
Regarding the safe home teleport - there was some changes to not burden the server so much when searching for a safe spot, so it can take a bit longer.

@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Monitoring Monitoring the issue to see if it is fixed or if more information becomes available Status: Under investigation Investigating the interest and the feasability of the issue. labels Nov 5, 2019
@tastybento
Copy link
Member

Try a new build and let me know if that works for you.

@tastybento
Copy link
Member

Reopen if you still see an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants