Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLite delete of non-existent entry does not fail silently #1010

Closed
tastybento opened this issue Oct 26, 2019 · 0 comments
Closed

SQLite delete of non-existent entry does not fail silently #1010

tastybento opened this issue Oct 26, 2019 · 0 comments
Assignees
@tastybento
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Milestone
1.9.0 - SpigotMC ...

Comments

@tastybento
Copy link
Member

Description

Describe the bug

Trying to delete an object that is not in the database from the database will throw console errors.
See BentoBoxWorld/Biomes#55

Steps to reproduce the behavior

Use API to delete an ID from the database that is not in the database when using SQLite.

Expected behavior

All other databases fail silently. For consistency, have SQLite be silent too. JavaDocs should be updated to explain this operation.
@tastybento tastybento added this to the 1.9.0 - SpigotMC release! milestone Oct 26, 2019
@tastybento tastybento self-assigned this Oct 26, 2019
@Poslovitch Poslovitch added the Status: In progress Working on the issue. label Oct 26, 2019
tastybento added a commit that referenced this issue Oct 26, 2019
@tastybento
Makes SQLite deletion of non-existent items fail silently
1304f8b 
Adds JavaDoc to make this clear.

#1010
@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Milestone
1.9.0 - SpigotMC release!
Development

No branches or pull requests
2 participants
@tastybento @Poslovitch