Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players are allowed to use /bentobox version #1002

Closed
NotMyFault opened this issue Oct 20, 2019 · 8 comments
Closed

Players are allowed to use /bentobox version #1002

NotMyFault opened this issue Oct 20, 2019 · 8 comments
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug

Comments

@NotMyFault
Copy link
Contributor

NotMyFault commented Oct 20, 2019

Description

Is your feature request related to a problem?

No, yet the version command contains some sensitive information (such as the storage type) which is not relevant to any player but for debug purposes, there's no need to make the command public accessible.

Describe the solution you'd like us to implement.

#1004

Describe alternatives you've considered.

Additional context

@Poslovitch
Copy link
Member

Poslovitch commented Oct 20, 2019

Good catch. I don't remember why I left it out as true instead of op.

yet the version command contains some sensitive information (such as the storage type).

I don't see why the storage type could be considered as "sensitive".

Though, the /bentobox version is clearly not targeted at players. So, the fix you're suggesting is totally ok.

@Poslovitch Poslovitch added Status: In progress Working on the issue. Type: Bug labels Oct 20, 2019
@Poslovitch Poslovitch added this to the 1.9.0 - SpigotMC release! milestone Oct 20, 2019
@Poslovitch Poslovitch changed the title Fix debug permissions Players are allowed to use /bentobox version Oct 20, 2019
@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Oct 20, 2019
@BONNe
Copy link
Member

BONNe commented Oct 20, 2019

I do not.. I liked to go into servers and check theri bentobox version :(

@NotMyFault
Copy link
Contributor Author

Let /bbox version return the license, addons loaded and bentobox version and rewrite /bbox about to somewhat of a debug command returning game worlds, database type and server version. Ezpz fix and you can still stalk BentoBox servers ;p

@Poslovitch
Copy link
Member

I'd rather keep /bbox v as is, and just add the BentoBox version in /bbox about

@BONNe
Copy link
Member

BONNe commented Oct 21, 2019

Could you explain a difference between version and about?

@Poslovitch
Copy link
Member

Version is the equivalent to Bukkit's /pl and /ver, whereas About is the equivalent to ASkyBlock's About, which shown license and authors.

@Poslovitch
Copy link
Member

Actually, /bentobox about already shows the BentoBox version.

@NotMyFault
Copy link
Contributor Author

Actually, I was just joking about its purpose haha lol, but a change seems to be helpful in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants