Skip to content

Commit

Permalink
Fix missing edge deletion of island.
Browse files Browse the repository at this point in the history
The bounding box was erroneously being made smaller when it was not
required because the inBounds check does that already.

#1863
  • Loading branch information
tastybento committed Oct 3, 2021
1 parent a1c3f78 commit 3c65194
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ public boolean inIslandSpace(Pair<Integer, Integer> blockCoordinates) {
* @since 1.5.2
*/
public BoundingBox getBoundingBox() {
return new BoundingBox(getMinX(), 0.0D, getMinZ(), getMaxX()-1.0D, world.getMaxHeight(), getMaxZ()-1.0D);
return new BoundingBox(getMinX(), 0.0D, getMinZ(), getMaxX(), world.getMaxHeight(), getMaxZ());
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,7 @@ public void testGetBoundingBox() {
i.setWorld(world);
when(location.getWorld()).thenReturn(world);
assertNotNull(i.getBoundingBox());
assertEquals("BoundingBox [minX=-400.0, minY=0.0, minZ=-400.0, maxX=400.0, maxY=0.0, maxZ=400.0]", i.getBoundingBox().toString());
}

/**
Expand Down

0 comments on commit 3c65194

Please sign in to comment.