make optionsLabel able to use nested object key

[ahmedsayedabdelsalam]

I use spatie translation package and I think many of us do

the translation columns are of json datatype like name = {"en": "dog", "de": "hund"}

I find that the form select input works well but the index and details pages are not working optionsLable('name')

also when setting optionsLabel like this optionsLabel('name.en')

I know we could make a computed attribute for that but it's painful to add those custom attributes everywhere.

I think making it can access nested key from object like optionsLabel('name.en') well be very helpful

[Benjacho]

First of all thank you for your contribution, could you make Readme about this? after that i will be able to merge this

[ahmedsayedabdelsalam]

First of all thank you for your contribution, could you make Readme about this? after that i will be able to merge this

done ✅

[SimonBarrettACT]

This doesn't seem to fix the issue in FormField.

[ahmedsayedabdelsalam]

@SimonBarrettACT make sure you use the LogsActivit trait.
and add protected $translatable = ['title']; to the model.
and make sure that the values used to represent the resource it title

[SimonBarrettACT]

My model was already set up as you suggested and this is my field entry:

BelongsToManyField::make('Towns', 'towns', 'App\Nova\Town')->optionsLabel('name.en')

but nothing is being displayed.

[SimonBarrettACT]

I'm not sure what you mean by:

@SimonBarrettACT make sure you use the LogsActivit trait.

[ahmedsayedabdelsalam]

Sorry, my mistake I meant the trait in the model as shown in the picture

I am not sure why it is not working with you
But I rechecked the code again an it's working with me.

[SimonBarrettACT]

It's strange. I can't see why it isn't working either. Thanks for your efforts to help though.

[ahmedsayedabdelsalam]

I wish I could help,
can you send me those files to [email protected] I'll try debugging this issue in my project?
if you're ok with that.
I need those files.
models and nova resources for the two sides of the relation.

[LouisHrg]

Hello !
I tried your fork and it works well, except on editing, i don't have any label displayed

[ahmedsayedabdelsalam]

@LouisHrg
at "create" form when you select something is it also appears like that?

[LouisHrg]

Nope it works fine, I'll try to fix the issue in a PR today, the issue seems to be in setInitialValue in FormField.vue

Update : here's the PR ahmedsayedabdelsalam#1

let me know 👍

[SimonBarrettACT]

I was having the same issue and have submitted a pull request #54 that fixes the issue by providing the ability to set the language used.

[ahmedsayedabdelsalam]

Nope it works fine, I'll try to fix the issue in a PR today, the issue seems to be in setInitialValue in FormField.vue

Update : here's the PR ahmedsayedabdelsalam#1

let me know 👍

@LouisHrg
sorry for the late reply. your PR fixes the issue. Thank you.

@SimonBarrettACT kindly recheck if it works now.

[SimonBarrettACT]

It works for me thanks.

[ahmedsayedabdelsalam]

@SimonBarrettACT Great 👌

@Benjacho waiting for your review.

[manyasone]

Works perfectly fine for me, too. Any chance this will be merged to the main repo in the near future? ;)

[Benjacho]

Already merged ty