Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check/fix tsv files to enable preview #233

Open
dweindl opened this issue Sep 17, 2024 · 1 comment
Open

Check/fix tsv files to enable preview #233

dweindl opened this issue Sep 17, 2024 · 1 comment

Comments

@dweindl
Copy link
Member

dweindl commented Sep 17, 2024

GitHub offers a nice tsv table preview, but this only works for well-behaved files.
For example, all rows need to have the same number of columns.
This is not always the case. See, for example,
https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab/blob/master/Benchmark-Models/Schwen_PONE2014/parameters_Schwen_PONE2014.tsv:

image

This probably happens during manual modification of tsv files in some IDEs that remove trailing whitespace.
We should add a pre-commit check for proper tsv.

@stephanmg
Copy link
Collaborator

stephanmg commented Sep 17, 2024

Also mixed line endings ^M and others are present in some files. (Might not be bad, but should also be consistent?)

dweindl added a commit that referenced this issue Sep 18, 2024
Fix tsv format in `parameters_Schwen_PONE2014.tsv`. See #233.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants