-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move encoder config to data driven based on #19923 #9
Conversation
Update config.h Update info.json
Update info.json Update config.h
"split": { | ||
"soft_serial_pin": "D2", | ||
"encoder": { | ||
"right": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do you found information, about the split encoder stuff.
There is no information about that here and could not find it elsewhere. https://docs.qmk.fm/#/reference_info_json?id=encoders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seen the information at the QMK discord: https://discord.com/channels/440868230475677696/440868230475677698/1015546413033193542
And also a concrete implementation at the splitkb kyria re3 board: https://github.com/qmk/qmk_firmware/blob/master/keyboards/splitkb/kyria/rev3/info.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also seen this in the big PR 19923 "Move encoder config to data driven"
https://github.com/qmk/qmk_firmware/pull/19923/files
e.g. for keyboards/aleblazer/zodiark/info.json
Thank you for your contribution! |
Thank you for your contribution! |
Move encoder config to data driven based on qmk#19923
Update config.h
Update info.json
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist