Fix crash at startup when all playback devices are disabled #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt returns Element Not Found (occurs when no playback devices are enabled).
|
Thanks for this, I'll have to investigate the other issue you pointed out. Can you open a different issue just with it ? |
Thanks for the review and commit! No problem I'll open a another issue for the 2nd problem I mentioned in #427 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #427
Simply uses a try-catch to check for COMException/E_NOT_SET.
The code could be simplier by removing the ErrorCode checking. But it becomes less robust that way since there might be other COMExceptions that we don't wanna ignore.
Please kindly review. :)