Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon in notification tray does not change when a hotkey is used to apply a profile #450

Closed
skst opened this issue May 18, 2020 · 22 comments
Closed

Icon in notification tray does not change when a hotkey is used to apply a profile #450

skst opened this issue May 18, 2020 · 22 comments
Labels
Bug Issues which are bug reports released

Comments

@skst
Copy link

skst commented May 18, 2020 •
edited
Loading

Describe the bug
When changing the profile with a hotkey, the notification icon does not change to the icon specified in the profile.

Version
SoundSwitch v5.0.4.31153

To Reproduce
Steps to reproduce the behavior:
1. I create two profiles ("A" and "B"), each with different hotkeys and Playback and Recording icons. Profile A is my current configuration.
2. In Settings, I set Systray Icon to Playback.
3. Note: the notification icon is the one for profile A.
4. I use one of the hotkeys to change to profile B.
5. Bug: The notification icon does not change to show the Playback icon for profile B. (It still shows the Playback icon for profile A.)

  1. I create two profiles ("A" and "B"), each with different hotkeys and Playback and Recording icons. Profile A is my current configuration. Profile B has different playback and recording devices.
  2. In Settings, I set Systray Icon to Playback.
  3. Note: the notification icon is the one for profile A.
  4. I use the hotkey to change to profile B.
  5. The notification icon changes to show the Playback icon for profile B.
  6. I use the hotkey to change to profile A.
  7. Bug: The notification icon does not change to show the Playback icon for profile A. (It still shows the Playback icon for profile B.)

Expected behavior
The notification icon should show the Playback icon for profile B when profile B is active.

Screenshots
I've attached three screenshots to show the profiles, Normal profile (correct icon), and Headset profile (incorrect icon).
Profiles
Normal
Headset
@skst skst added the Bug Issues which are bug reports label May 18, 2020
@Belphemur
Copy link
Owner

Hello @skst,

I'm not able to reproduce your issue.
issue-450

For me the icon does change when I change the profile.
Do you see a notification telling you the device changed ?

@skst
Copy link
Author

skst commented May 18, 2020

Hmm. Yes, I do see the banner telling me the profile changed. Here are screenshots of my Settings (in case that's relevant) and the banner.
banner
Settings

@skst
Copy link
Author

skst commented May 20, 2020

I've noticed that, after restarting Windows, the icon changes the first time I switch to a profile using a hotkey. After that, however, it does not change when I change profiles.

Of course, I can't guarantee that something else isn't affecting it, but I hope this helps.

@Belphemur
Copy link
Owner

I'm sorry it's hard to understand what is exactly happening ...

Do you have that issue with other dynamic systray icons ?

@skst
Copy link
Author

skst commented May 22, 2020

Sorry. I'll endeavor to clarify.

  1. I create two profiles ("A" and "B"), each with different hotkeys and Playback and Recording icons. Profile A is my current configuration. Profile B has different playback and recording devices.
  2. In Settings, I set Systray Icon to Playback.
  3. Note: the notification icon is the one for profile A.
  4. I use the hotkey to change to profile B.
  5. The notification icon changes to show the Playback icon for profile B.
  6. I use the hotkey to change to profile A.
  7. Bug: The notification icon does not change to show the Playback icon for profile A. (It still shows the Playback icon for profile B.)

(I've also updated the original post.)

@Belphemur
Copy link
Owner

This is the exact scenario I've tested ...
I'm not able to reproduce neither understand what is happening on your machine ...

@skst
Copy link
Author

skst commented May 23, 2020

If I haven't made it clear what's happening on my machine, you probably haven't been able to test the exact scenario. 🙂

Can you tell me which of my steps to reproduce the issue aren't clear so that I can try to improve how I'm describing the issue?

Summary: The notification icon changes only the first time that I use a hotkey to change the profile. After that, the notification icon never changes again.

@Belphemur
Copy link
Owner

Belphemur commented May 31, 2020 •
edited
Loading

Can you try with v5.3.0 ?

Not sure it will fix your issue, but since there has been some changes to the profile feature and to the core of the app, it might.

@skst
Copy link
Author

skst commented May 31, 2020

I installed 5.3.0 over my previous install. The notification icon does not change when I use a profile hotkey.

@Belphemur
Copy link
Owner

Belphemur commented May 31, 2020 via email

@skst
Copy link
Author

skst commented May 31, 2020

A good thought, but sadly, that's not the case. In addition to the screenshots I provided in the OP showing the icons in the profiles which are the ones that SoundSwitch displays in the banners and for the notification icon, here are the icons of the playback devices themselves.

Untitled

@Belphemur
Copy link
Owner

Belphemur commented May 31, 2020 via email

@skst
Copy link
Author

skst commented May 31, 2020

Absolutely, icons can have different images for different sizes. But, yes, I changed the headset icon just in case and, no, it didn't change. You know better than I do, but it appears that those aren't the icons that SoundSwitch uses since the "speakers" icon doesn't match the one SoundSwitch lists in the profile.

@Belphemur
Copy link
Owner

It does use that icon, but there is a cache in place. It won't change if the icon is currently in use.

If you have the settings open when changing the icon, the change won't be reflected until you reopen the settings.

I admit, I'm not able to understand what isn't working in your setup ...

Last idea, can you download and assign this icon to one of the two device ?
https://soundswitch.aaflalo.me/favicon.ico

Then do the profile switching.

@skst
Copy link
Author

skst commented Jun 1, 2020 •
edited
Loading

I don't have the system settings nor the SoundSwitch settings open when I change profiles. I also don't think I ever changed the system icon. Please note that the icons shown for the SoundSwitch profiles match the system icons, however the icon shown in the notification area does not match any of them.

I assigned the icon to the Speakers device. I used the hotkey to change to the Headset profile. The icon didn't change. I used the hotkey to change to the Normal profile (with the Speakers device). The icon didn't change.
upload

@amerker
Copy link

amerker commented Mar 18, 2021

I have the same issue, after setting up SoundSwitch on a new PC.
SoundSwitch 5.7.2.29590, Win 10 Pro 20H2.

The problem is related only to the Playback devices, and it's most obvious when I have Systray Icon set to "Playback".
It correctly switches if "Recording" or "Both" is selected, though in the latter case I can only see the recording device switching.

The icons of the Playback devices themselves are fine and distinct, as I can see when switching directly via the Ctrl-Alt-F11 hotkey.

The workaround for me right now is that I keep it set to Both and simply benefit from both Recording devices in my profiles having different icons.

@mrgoodwin
Copy link

I can confirm the exact behavior @amerker describes. I have two profiles configured. One that uses my speakers for playback and my webcam for recording. The other profile uses my headset for both playback and recording. I have a hotkey assigned to each profile. I have distinct icons set for each device in Windows Sound Settings and SoundSwitch is set to display the Playback icon in the notification area,

When I use the global Ctrl-Alt-F11 hotkey to cycle through playback devices, the system tray icon updates to show the correct playback device. If I use the left-click menu to select a playback device, the system tray icon updates correctly as well.

But if I trigger either of my profiles (type of trigger doesn't seem to matter) the system tray icon does not update. It just stays with whatever icon it was showing before.

SoundSwitch Stable 5.11.2.39643 Win 10 Pro 20H2, also a new PC and a fresh install of SoundSwitch. What's really frustrating is this was working just fine on my old system.

@Belphemur
Copy link
Owner

I think I might have found the issue with this one.

Can you check with v6.1.2 if it's fixed ?

@skst
Copy link
Author

skst commented Oct 13, 2021 •
edited
Loading

Sorry, no. It's still an issue in 6.1.2.0.

image

image

Belphemur added a commit that referenced this issue Oct 13, 2021
@Belphemur
boost(TrayIcon): Add better logs to understand what's happening with …
99d6243 
…the systray icon not changing.

See #450
@Belphemur
Copy link
Owner

@skst Can you join me on Discord, I have a beta version with better logs to try to understand what is happening here.

Discord:
https://discord.gg/gUCw3Ue

Link of the beta:
https://f000.backblazeb2.com/file/SoundSwitch/nightly/SoundSwitch-dev.zip

@skst
Copy link
Author

skst commented Oct 13, 2021

I'm now in the SoundSwitch Discord server as skst. I zipped my install folder and unzipped SoundSwitch-dev.zip into it. I ran it and reproduced the issue. Where do I find the logs to send to you, and how would you prefer to receive them?

github-actions bot pushed a commit that referenced this issue Oct 23, 2021
@semantic-release-bot
chore(release): 6.2.0 [skip ci]
9ccaffc 
## [6.2.0](v6.1.2...v6.2.0) (2021-10-23)

### Features

* **AudioSwitching:** Add support for Windows 11 ([b2e1de5](b2e1de5)), closes [#797](#797) [#548](#548)

### Bug Fixes

* **AudioSwitcher::Windows11:** Fix possible crash when using profile with application on Windows 11 ([8531ee9](8531ee9))
* **AudioSwitcher:** Properly use the right audio client for Windows post 21H2 (like Windows 11) ([7324b15](7324b15))
* **DeviceLister:** Fix crash when device lister is taking too long ([e7efb5c](e7efb5c))
* **Notification::Sound:** Fix crash when playing a custom sound. ([f0a7113](f0a7113)), closes [#790](#790)
* **Profile:** Fix systray icon not changing properly when using a profile ([aef15b7](aef15b7)), closes [#450](#450)

### Languages

* **Russian:** Translated Settings using Weblate ([24cb961](24cb961))

### Enhancements

* **AudioSwitcher:** Improve the logging of the switching for Windows 11 ([5e0a985](5e0a985))
* **Mute:** Change the unmute icon ([844ad5f](844ad5f)), closes [#791](#791)
* **Mute:** Improve the image to have the same size as device icon ([a840c82](a840c82)), closes [#791](#791)
* **TrayIcon:** Add better logs to understand what's happening with the systray icon not changing. ([99d6243](99d6243)), closes [#450](#450)
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 6.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues which are bug reports released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@skst @Belphemur @amerker @mrgoodwin