-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on Launch, Win7 x64 #161
Comments
Do you remember which kind of Notification (None,Windows,Sound,Toast,Custom) you had configured to show up if you changed your devices? The error occurred because you are using Windows 7 and configured: The easiest way to fix your problem is to delete the configuration file: Edit: 0bc54a4#diff-e5c0d47cc4eb7013b7b5cb73a9c1f456R18 I didn't noticed that these settings are serialized as integer values. |
@FireEmerald it surely that yes. We need to either put them in the order they were or add a backward compatible setting in the configuration. The easiest is to rechange the order in the enumerated. I missed that change when reviewing the pull request. |
@ReanimationXP is I'm sorry but for now you'll have to remove the %appdata%/SoundSwitch directory to start with a fresh configuration. |
In that case I'll add a fallback for the notification setting. Since each notification has an IsAvailable method.
This way we'll avoid this type of crash.
It would be nice to know how this setting has been set in the first time.
Sent from BlueMail
…On Mar 5, 2017, 08:25, at 08:25, FireEmerald ***@***.***> wrote:
Well, but `"NotificationSettings": 3` wasn't changed - so the source of
this crash shouldn't be the localization commit.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#161 (comment)
|
It would be better to assign each Enum a value which is used in the configuration instead of the code order. Then we could change the order without any problems. |
The only file changes which lead to this crash is located here: NotificationTypeEnum.cs. |
References Notification creation I think. This happens with damn near every version, even ones which have worked. I suspect a restart would fix, but keeps happening.
Also Github wouldn't let me upload the zip you're generating. Even after trying a handful of evasion bullshit. Uploaded it here:
https://mega.nz/#!sNQjHbhS!5UIV1uG2dDuuD7CwB5NSIvYgtSyMd0wrZ0K9Vy0wnn4
The text was updated successfully, but these errors were encountered: