Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-select): prompt visibility, border, and fzf menu position #123

Closed
wants to merge 1 commit into from

Conversation

willothy
Copy link
Collaborator

  1. Title pos should be based on win_configs, not arbitrarily set. Not sure why I had it like that.
  2. Ensures prompt is always visible by adding a solid top-border if border == "none"
  3. Only uses virt_text value if it's a table to ensure that multiple return values from string methods like gsub are ignored.

fix(ui-select): only use virt_text if value is table
@willothy willothy marked this pull request as ready for review December 23, 2023 18:54
@Bekaboo
Copy link
Owner

Bekaboo commented Dec 24, 2023

I also have some thoughts to improve the ui-select function, see my config here

I would like to merge my changes with yours and finally to master, but I am currently a bit busy right now and might do it after one or two weeks.

@willothy
Copy link
Collaborator Author

I also have some thoughts to improve the ui-select function, see my config here

I would like to merge my changes with yours and finally to master, but I am currently a bit busy right now and might do it after one or two weeks.

No rush, sounds good! Your changes look good as well, I'll test them out.

@willothy
Copy link
Collaborator Author

@Bekaboo I can also merge your changes into this PR if you'd like, I have some free time this week. If you would prefer to do it that's cool though, no rush.

@Bekaboo
Copy link
Owner

Bekaboo commented Dec 26, 2023

Sounds cool! You are welcome to do it if you have free time.

@willothy
Copy link
Collaborator Author

Sounds cool! You are welcome to do it if you have free time.

After merging in your changes and trying a few different configurations, I have noticed some edge cases with the way the fzf prompt window opens. These mostly relate to border. I am going to mark this as a draft and do some more work fixing these edge cases, and I'll request review when it's ready. I think I will likely turn all border props into arrays and modify them so that theming can be consistent while still allowing configuration.

@willothy willothy marked this pull request as draft December 26, 2023 23:56
@willothy willothy changed the title fix(ui-select): ensure prompt is visible fix(ui-select): prompt visibility, border, and fzf menu position Dec 26, 2023
@Bekaboo
Copy link
Owner

Bekaboo commented Jan 20, 2024

Close this by commit 0c3b4f6. Reopen if you have any further improvements or bug fixes.

@Bekaboo Bekaboo closed this Jan 20, 2024
@willothy
Copy link
Collaborator Author

willothy commented Jan 20, 2024

Totally, sounds good! My bad, didn't end up having time to finish this.

I'll look into the edge cases I found and open a separate PR for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants