Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add color to kind's text, not just icon #18

Closed
nullchilly opened this issue Jun 1, 2023 · 5 comments
Closed

[Feature]: Add color to kind's text, not just icon #18

nullchilly opened this issue Jun 1, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@nullchilly
Copy link
Contributor

nullchilly commented Jun 1, 2023

Problem

Currently the winbar fg rely on the WinBar highlight group

image

This makes it hard to add dropbar.nvim integration to colorscheme. If I change the WinBar highlight to make dropbar prettier, vanilla user will not be happy.

Expected behavior

Add DropBarNormal = { link = "WinBar", default = true } so colorscheme can add dropbar integration easier:

image

Add color_mode to show color for kind's text and not just its color, via DropBarKindFunction highlight group instead of just for icon (DropBarIconKindFunction)

image

@nullchilly nullchilly added the enhancement New feature or request label Jun 1, 2023
@Bekaboo
Copy link
Owner

Bekaboo commented Jun 1, 2023

This is a good idea, but I hesitate to implement this since currently the text color depends on not only hl-WinBar but also hl-WinBarNC, which make it possible to highlight texts in winbars of non-current windows in a different colors.

If I set the highlights groups explicitly and link it to hl-WinBar by default, we will no longer respect hl-WinBarNC.

Any thoughts?

@nullchilly
Copy link
Contributor Author

nullchilly commented Jun 1, 2023

I guess we can make DropBarNormal an empty highlight group by default

:lua vim.o.winbar = "%#DropBarNormal# dropbar.lua"

image

WinBarNC still works. Now if you define the highlight group:

:hi DropBarNormal guifg=#cba6f7

image

@Bekaboo
Copy link
Owner

Bekaboo commented Jun 1, 2023

Looks good will look into it later.

@nullchilly
Copy link
Contributor Author

nullchilly commented Jun 3, 2023

@Bekaboo Special thanks :)

I implemented it in catppuccin/nvim#499

Before

image

After

color_mode = false

image

color_mode = true

image

@Bekaboo
Copy link
Owner

Bekaboo commented Jun 3, 2023

👍🏼 Good job! I'm always impressed by how configurable and aesthetic catppuccin is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants