Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-select): support optional preview of items #124

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

willothy
Copy link
Collaborator

Adds optional preview support to the ui-select menu, via the preview and preview_close fields on the options table.

@willothy
Copy link
Collaborator Author

willothy commented Dec 26, 2023

Depends on #123, do not merge

@willothy willothy added the enhancement New feature or request label Dec 26, 2023
@willothy
Copy link
Collaborator Author

@Bekaboo I rebased this on top of master so it no longer depends on the closed PR - thoughts? I use this in my config for previewing code actions:

https://github.com/willothy/nvim-config/blob/3a9a036bccb5f06d92ddbc52eb548da0ae0b3521/lua/willothy/modules/ui/code_actions.lua#L473

@Bekaboo
Copy link
Owner

Bekaboo commented Jan 23, 2024

Thanks, looks great! I are going to merge this after dealing with #131

@willothy
Copy link
Collaborator Author

Thanks, looks great! I are going to merge this after dealing with #131

Awesome, sounds good!

@willothy
Copy link
Collaborator Author

willothy commented Feb 5, 2024

@Bekaboo ready to merge this one soon? It's pretty minimal

@Bekaboo
Copy link
Owner

Bekaboo commented Feb 7, 2024

Yep, sorry for the delay.

@Bekaboo Bekaboo merged commit f835519 into Bekaboo:master Feb 7, 2024
4 checks passed
@Bekaboo
Copy link
Owner

Bekaboo commented Feb 7, 2024

@willothy vimdoc missing

@willothy
Copy link
Collaborator Author

willothy commented Feb 7, 2024

Oops, my bad! I keep forgetting to mirror the readme changes to the vimdoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants