This repository has been archived by the owner on May 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Documentation development versions support #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the changes in Version, we can not use it anymore to retrieve packages after build because every time we provide `v2.0` to it it is used to build `v2.0.x` version string. Which is right in the release domain, but is not really in the documentation domain.
0b6aa66
to
fd22cdf
Compare
Scenario: Publishing extension release documentation | ||
Given "behat/symfony2-extension" version "v2.0.0" was documented in "Behat/Symfony2Extension" | ||
When I release "Behat/Symfony2Extension" version "v2.0.0" | ||
Then "behat/symfony2-extension" version "v2.0" documentation should have been published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why v2.0
here while the Behat doc scenarios are using v2.5.x
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New release of
v2.5
(which is most likely a branch) results in (re-)build ofv2.5.x
version of the docs. - New release of
v2.5.3
(which is most likely a tag) results in (re-)build of stablev2.5
version of the docs
This way every time somebody updates v2.5
or v2.5.x
branch of the docs we do rebuild them, but as v2.5.x
version, without actually overriding the latest stable version of the same minor (which is v2.5
) :)
@stof are you ok with this being merged? |
yes |
everzet
added a commit
that referenced
this pull request
Jan 7, 2015
…-versions Documentation development versions support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second and last part of #7
Effectively closes #7