Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of camconst files #7245

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Lawrence37
Copy link
Collaborator

In ART, the camera constants are separated into 4 files for better maintainability:

  • camconst.json: The main place to add camera constants. This is mainly used for raw crops, white/black levels, PDAF lines patterns, and color matrices.
  • dcraw.json: Constants from dcraw.c. Useful if dcraw starts receiving updates again.
  • rt.json: dcraw overrides in RawTherapee. A better place to put overrides than in the code.
  • cammatrices.json: A new file containing color matrices from Adobe DNG Converter. Easy to update with the included Python script.

This pull request adds the same functions to RawTherapee. cammatrices.json is identical to ART master, which is updated with Adobe DNG Converter 16.5. The current version is 17.0. cammatrices.json should be updated before each release using the latest version of ADC.

Create dcraw.json for dcraw constants, rt.json for RawTherapee overrides
for dcraw, and cammatrices.json for color matrices from Adobe DNG
Converter.

Cherry-picked from ART, commit 4f360f3a883f6920f6507c533646db275853093f.
@Lawrence37 Lawrence37 added type: enhancement Something could be better than it currently is scope: calibration Camera calibration (camconst.json) labels Nov 10, 2024
@Lawrence37 Lawrence37 added this to the v5.12 milestone Nov 10, 2024
@Lawrence37 Lawrence37 self-assigned this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: calibration Camera calibration (camconst.json) type: enhancement Something could be better than it currently is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant