Improvements of Locallab GUI #5727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: - All Locallab tools have been converted to this new design - Locallab GUI hasn't been updated to this new design Bugfix: Solve crash problem when using ctrl+copy/ctrl+paste
Improvements: - Simplification of default values setting/management Limitations: - Possibility to add/remove Locallab tool isn't working - Even if not fully deactivated, batch mode isn't working anymore for Locallab - Mask preview isn't working anymore
Changes:
- Mask preview has been improved. It only applies on detailed image now
("dcrop" pipeline) which corrects unexpected behavior on navigator
image. Mask preview now only applies on selected spot: when switching
between spots, mask preview is deactivated on newly selected spot.
- Image reprocessing is now avoided when switching between spots (except
if mask preview was previously activated). Mask background update
remains functionnal.
Bugfixe:
- AStyle runned on several modified files
Change: - Use tools list widget to add a Locallab tool to currently selected spot. Remove Locallab tool from currently selected spot using cross on tool title bar Note: - Spot parameters list in .pp3 file isn't optimized according to added/removed Locallab tools
Preliminary work: "nbspot" and "id" spot parameters have been removed to simplify Locallab spots management.
- Log Encoding cannot be added to RT-spot - RT crashes when "duplicate" or "delete" button is used without RT-spot
- When a tool was removed with mask visibility active - When an active mask visibility combobox was hidden due to other GUI action
Also fixes an issue where Blur, Noise & Denoise mask curves weren't available for all complexity mode
Another fixes: - Merge problems in default language file - Remove useless "printf"
- Adjusters "transitweak_" and "thresh_" are now present in all modes - Modification of maximum value of "transitweak_" adjuster
RT-spot points are now stored as integer vector (instead of four dedicated integer) to allow future improvements.
|
Thank you for this beautiful work :) I just merge this "pull request" with "newlocallab Beep65981". And I will wait, all checks (MacOS, et.) before create a PULL REQUEST with dev Thank you Jacques |
|
This pull request fixes 3 alerts when merging 50ad85b into 5d66b89 - view on LGTM.com fixed alerts:
|
|
Que penses-tu de ces alerts ? jacques |
|
@Desmis Pierre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Desmis
Hello All,
This Pull Request contains some improvements of Locallab GUI:
Pierre