Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): widen the peerDependencies in the package.json's #137

Merged
merged 1 commit into from
May 17, 2024

Conversation

jpoissonnet
Copy link
Contributor

🤔 Why?

When using theses packages with our app. The peerDependencies resolutions makes our package manager warn us about unmet peerDependencies.

We want to be able to use react-i18n with React 18.

We want to be able to use eslint-plugin-i18n.

💻 How?

We widen the peerDependencies specifier:

  • We want to allow React 18 to work with react-i18n with '|| ^18.0.0'
  • We want to allow any Eslint version above 4.0.0

@coveralls
Copy link

coveralls commented May 13, 2024

Pull Request Test Coverage Report for Build 9064851099

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.823%

Totals Coverage Status
Change from base Build 7399423202: 0.0%
Covered Lines: 192
Relevant Lines: 198

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9064851099

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.823%

Totals Coverage Status
Change from base Build 7399423202: 0.0%
Covered Lines: 192
Relevant Lines: 198

💛 - Coveralls

@jpoissonnet jpoissonnet requested review from flepretre and fdubost May 15, 2024 08:17
@flepretre flepretre merged commit 83b0341 into master May 17, 2024
5 checks passed
@flepretre flepretre deleted the widen-peerdeps-range branch May 17, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants