Add Perdiodic Timer and nextiterationSleepingTime #29
Conversation
DocRoms
force-pushed
the
feature/add-event-loop-documentation
branch
from
c873c05 to
805f0f9
Compare
README.md
Outdated
| @@ -41,6 +41,8 @@ m6_web_daemon: | |||
|
|
|||
| ## Write command | |||
|
|
|||
| This command use the [event-loop component](https://github.com/reactphp/event-loop#usage) that uses [ReactPHP](https://reactphp.org) for execute loops; and other tasks asynchronously. | |||
README.md
Outdated
| @@ -64,6 +66,16 @@ class MyDaemonizedCommand extends DaemonCommand | |||
|
|
|||
| // Add your own optional callback : called every 10 iterations | |||
| $this->addIterationsIntervalCallback(10, [$this, 'executeEveryTenLoops']); | |||
|
|
|||
| // You can add your own Periodic Timer, | |||
| // In this timer will be called every 0.5s. | |||
There was a problem hiding this comment.
// here this timer will be called every 0.5s
README.md
Outdated
|
|
||
| // You can add your own Periodic Timer, | ||
| // In this timer will be called every 0.5s. | ||
| $daemon = $this; |
There was a problem hiding this comment.
i'm pretty sure that PHP already binds $this with the anonymous function parent context
So i'm 90% sure that you can simply do:
$this->loop->addPeriodicTimer(0.5, function ($timer) {
if ($this->isLastLoop()) {
$this->loop->cancelTimer($timer);
}
});There was a problem hiding this comment.
That is true... Since PHP 5.4 :P See here for details
👍 Thank you
README.md
Outdated
| // This method helps to give back the CPU to the react-loop (here for 1000 $µseconds). | ||
| // So you can wait between two iterations if your workers has nothing to do. | ||
|
|
||
| // We do not recommand to use sleep() or usleep() anymore. |
There was a problem hiding this comment.
recommand
=> recommend
Is there somewhere else in the doc where we did recommend sleep() or usleep() ? Because if it's true, we should also remove these recommendations
anyway, I'm not sure we should say that we recommended it before, it's in the git history forever now, they can look for older versions if they want to see our previous recommendations :)
README.md
Outdated
| // So you can wait between two iterations if your workers has nothing to do. | ||
|
|
||
| // We do not recommand to use sleep() or usleep() anymore. | ||
| $this->setNextIterationSleepingTime(1000); // Every milliseconds |
There was a problem hiding this comment.
you should use another value, this one may be confusing because you put 1000 and say milliseconds
I'd suggest to either explicitly say Every 1000 microseconds
or to use another value instead:
$this->setNextIterationSleepingTime(1000000); // Every second
DocRoms
force-pushed
the
feature/add-event-loop-documentation
branch
2 times, most recently
from
d8fc75c to
3450780
Compare
README.md
Outdated
|
|
||
| usleep(100000); | ||
|
|
||
| // This method helps to give back the CPU to the react-loop (here for 1000 $µseconds). |
There was a problem hiding this comment.
remove (here for 1000 $µseconds)?
README.md
Outdated
| // This method helps to give back the CPU to the react-loop (here for 1000 $µseconds). | ||
| // So you can wait between two iterations if your workers has nothing to do. | ||
|
|
||
| $this->setNextIterationSleepingTime(1000000); // Every seconds |
There was a problem hiding this comment.
I'm not so sure about that but I think the word after every should not be pluralized, because it means "chaque" in french...
I think 👉 @pabedu 👈 taught me that (you can hit him if it's wrong)
Update comment Add link to reactPhp Edit comments and add link review Fix Add Note for old PHP version Typo
DocRoms
force-pushed
the
feature/add-event-loop-documentation
branch
from
3450780 to
af9361d
Compare
Update the documentation for DaemonBundle usage.