Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameters names should be homogeneous #2

Closed
evadelmas opened this issue Oct 7, 2021 · 3 comments
Closed

Parameters names should be homogeneous #2

evadelmas opened this issue Oct 7, 2021 · 3 comments
Assignees
@evadelmas
Milestone
0.0.1

Comments

@evadelmas
Copy link
Collaborator

e.g. for the functional reponse, h vs hill_exponent, c vs interference, etc
@evadelmas evadelmas self-assigned this Oct 7, 2021
@evadelmas evadelmas added this to the 0.0.1 milestone Oct 7, 2021
@ismael-lajaaiti
Copy link
Collaborator

@evadelmas Is this question addressed or not yet? I think that now parameter names are homogeneous, but I will double-check and try to think if some parameters could be better named. Anyway let me know if you have any suggestions of parameter name modifications.

@iago-lito
Copy link
Collaborator

FWIW the sophisticated API for MultiplexNetwork makes it possible / safe to provide "official" aliases for parameters now, in the sense that they are acknowledged and supported by the package, and that we can check upfront that they carry no ambiguities.
This would require a little bit of dev and careful use of the new AliasingDict structures though. It is also very uncommon in other Julia packages as far as I am aware of.

alaindanet added a commit that referenced this issue Feb 4, 2023
@alaindanet
🌪️#2: reframe diversity indices and tests
e84bb7c
alaindanet added a commit that referenced this issue Feb 4, 2023
@alaindanet
🌪️#2: reframe diversity indices and tests
a95c099
alaindanet added a commit that referenced this issue Feb 8, 2023
@alaindanet
🌪️#2: reframe diversity indices and tests
978196a
iago-lito pushed a commit that referenced this issue Feb 21, 2023
@alaindanet @iago-lito
🌪️#2: reframe diversity indices and tests
1f23525
alaindanet added a commit that referenced this issue Mar 8, 2023
@alaindanet
🌪️#2: reframe diversity indices and tests
07e68a9
@iago-lito
Copy link
Collaborator

Should be solved as #114 is adressed.

@iago-lito iago-lito mentioned this issue Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evadelmas evadelmas

Labels
None yet
Projects
None yet
Milestone
0.0.1
Development

No branches or pull requests
3 participants
@iago-lito @evadelmas @ismael-lajaaiti