Fix early return in lowLevelLocalizingSlice init #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the `lowLevelLocalizingSlice` took an empty region, we just returned from the initializer and I was expecting the compiler to insert the default field init. However, the compiler does not do that, which leaves the fields uninitialized. This leaves them with random values, which was causing issues where the record had a random address and isOwned value, which caused us to try and free a random address in deinit. Here just manually init the fields to work around this. I opened chapel-lang/chapel 18524 upstream to request an error message
|
This was noticed while trying to upgrade to 1.25, which changed the stack layout in some way that led to |
stress-tess
approved these changes
Oct 6, 2021
glitch
approved these changes
Oct 6, 2021
reuster986
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the
lowLevelLocalizingSlicetook an empty region, wejust returned from the initializer and I was expecting the compiler to
insert the default field init. However, the compiler does not do that,
which leaves the fields uninitialized. This leaves them with random
values, which was causing issues where the record had a random address
and isOwned value, which caused us to try and free a random address in
deinit. Here just manually init the fields to work around this.
I opened chapel-lang/chapel#18524 upstream to request an error message