Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3960: python interface for CommDiagnostics #3966

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Closes #3960: python interface for CommDiagnostics #3966

merged 2 commits into from
Jan 10, 2025

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Jan 9, 2025

This PR adds a comm_diagnostics module with the functions start_comm_diagnostics, stop_comm_diagnostics, reset_comm_diagnostics, print_comm_diagnostics_table and other communication diagnostics statistical functions. These functions act as a python interface to the chapel functions startCommDiagnostics, stopCommDiagnostics, resetCommDiagnostics, printCommDiagnosticsTable, and getCommDiagnostics.

Closes #3960: python interface for CommDiagnostics

@ajpotts ajpotts force-pushed the 3960_python_interface_for_CommDiagnostics_cpy2 branch from 154d6fc to 0e57ded Compare January 9, 2025 20:45
@ajpotts ajpotts marked this pull request as ready for review January 9, 2025 20:46
drculhane
drculhane reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@drculhane drculhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add comm_diagnostics_test.py to pytest.ini. I did run the test manually. It skipped multi_locale (I hadn't compiled with GasNet), but everything else passed.

tests/comm_diagnostics_test.py Outdated Show resolved Hide resolved
arkouda/comm_diagnostics.py Show resolved Hide resolved
@ajpotts ajpotts force-pushed the 3960_python_interface_for_CommDiagnostics_cpy2 branch from 3aa79eb to 0a480f8 Compare January 10, 2025 14:47
@ajpotts
Copy link
Contributor Author

ajpotts commented Jan 10, 2025

I added the tests to the pytest.ini. @drculhane Thanks for the reminder.

jaketrookman
jaketrookman approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ajpotts ajpotts added this pull request to the merge queue Jan 10, 2025
Merged via the queue into Bears-R-Us:master with commit a3aa4c3 Jan 10, 2025
19 checks passed
jabraham17 pushed a commit to jabraham17/arkouda that referenced this pull request Jan 21, 2025
@ajpotts @jabraham17
Closes Bears-R-Us#3960: python interface for CommDiagnostics (Bears-R…
91340c1 
…-Us#3966)

Co-authored-by: Amanda Potts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drculhane drculhane drculhane left review comments

@jaketrookman jaketrookman jaketrookman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python interface for CommDiagnostics
3 participants
@ajpotts @jaketrookman @drculhane