Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 2 of #3957: simplify offline builds #3959

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Jan 4, 2025

This PR separates the target arrow-download-source from the target install-arrow in the Makefile. It also makes the corresponding change to the other installs. This is in order to have the ability to download the dependencies on one system, move the dependencies to another system, and then install them on the second system. Otherwise, when the install script is run in the build directory, text files are created which have some paths hard coded.

Part of #3957

@ajpotts ajpotts force-pushed the offline_build_scripts_pr1 branch 3 times, most recently from 58342bf to a9a31a4 Compare January 7, 2025 13:39
@ajpotts ajpotts force-pushed the offline_build_scripts_pr1 branch from f45a64d to 4d2724c Compare January 7, 2025 14:29
@ajpotts ajpotts marked this pull request as ready for review January 7, 2025 15:02
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ajpotts ajpotts added this pull request to the merge queue Jan 8, 2025
Merged via the queue into Bears-R-Us:master with commit 7869b4a Jan 8, 2025
19 checks passed
jabraham17 pushed a commit to jabraham17/arkouda that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants