Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #3911 reduction performance improvements #3914

Merged

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Nov 22, 2024

This PR replaces the globals calls in pdarrayclass with setattr instead. This is more efficient as it adds the functions to the module level rather than the global dictionary.

Part of #3911 reduction performance improvements

@ajpotts ajpotts marked this pull request as ready for review November 25, 2024 14:26
Copy link
Contributor

@drculhane drculhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward. Good work!

Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ajpotts ajpotts added this pull request to the merge queue Dec 17, 2024
Merged via the queue into Bears-R-Us:master with commit a77be87 Dec 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants