Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3905: assert_equivalent to compare shapes of pdarrays #3906

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Closes #3905: assert_equivalent to compare shapes of pdarrays #3906

merged 1 commit into from
Dec 4, 2024

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Nov 20, 2024 •
edited
Loading

This adds checks to the assert_arkouda_pdarray_equal function to also check that ndims, size, and shape are all equal.

Closes #3905: assert_equivalent to compare shapes of pdarrays

@ajpotts ajpotts force-pushed the 3905_assert_equivalent_to_compare_shapes_of_pdarrays branch 2 times, most recently from f7411cb to 8c0dbca Compare November 20, 2024 17:00
@ajpotts ajpotts marked this pull request as ready for review November 20, 2024 18:21
drculhane
drculhane approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@drculhane drculhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

jaketrookman
jaketrookman approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ajpotts ajpotts force-pushed the 3905_assert_equivalent_to_compare_shapes_of_pdarrays branch from 96fcef4 to 78ee608 Compare December 3, 2024 23:37
@ajpotts ajpotts enabled auto-merge December 3, 2024 23:38
@ajpotts ajpotts added this pull request to the merge queue Dec 4, 2024
Merged via the queue into Bears-R-Us:master with commit 71102f8 Dec 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drculhane drculhane drculhane approved these changes

@jaketrookman jaketrookman jaketrookman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assert_equivalent to compare shapes of pdarrays
3 participants
@ajpotts @jaketrookman @drculhane