Part of #3839 new benchmarks to output performance graph format #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
changed the title
ajpotts
force-pushed
the
3839-new-benchmarks-to-output-performance-graph-format
branch
7 times, most recently
from
850e8c8 to
2f142dc
Compare
drculhane
reviewed
Nov 21, 2024
drculhane
reviewed
Nov 21, 2024
drculhane
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
I've made a couple of comments in the code. Other than that, (1) there's a lot in here, and while the code is straightforward, I'm like a member of a doctoral defense committee -- I just don't know this stuff well enough to confirm it, and I'm not able to generate test data to check it, and there aren't any tests included, however (2a) this is a utility to be used on the output of arkouda, as I understand it, so tests aren't necessarily needed, and (2b) the code is well-written with clear intent. In my judgment, it merits approval, although I'd appreciate some feedback on my comments below, and a walkthrough in our next team meeting, if that's feasible, would be nice.
ajpotts
force-pushed
the
3839-new-benchmarks-to-output-performance-graph-format
branch
from
0069e0c to
e60ebde
Compare
jaketrookman
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script
benchmark_v2/reformat_benchmark_results.pyto convert the benchmark results from json to a format that matches the chapel team viz. It only processes this forargsort,coargsort, andaggregate. The other benchmarks will be added in a future PR.Part of #3839 new benchmarks to output performance graph format