Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3886 refactor idx reduction msg #3889

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Closes #3886 refactor idx reduction msg #3889

merged 2 commits into from
Nov 20, 2024

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Nov 8, 2024

This PR adds new argmin and argmax chapel functions to replace the idxReductionMsg and remove the associated @arkouda.registerND annotation.

Closes #3886 refactor idx reduction msg

@ajpotts ajpotts force-pushed the 3886_refactor_idxReductionMsg branch 2 times, most recently from 19fb1a2 to 4ab8a9c Compare November 8, 2024 22:57
@ajpotts ajpotts marked this pull request as ready for review November 8, 2024 22:57
ajpotts
ajpotts commented Nov 13, 2024
View reviewed changes
tests/pdarrayclass_test.py Outdated Show resolved Hide resolved
ajpotts
ajpotts commented Nov 13, 2024
View reviewed changes
src/ReductionMsg.chpl Outdated Show resolved Hide resolved
stress-tess
stress-tess approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks amanda

@ajpotts ajpotts force-pushed the 3886_refactor_idxReductionMsg branch 3 times, most recently from 9392c73 to 50fa6f2 Compare November 15, 2024 18:24
drculhane
drculhane approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@drculhane drculhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the multiple cases of argmax and argmin a bit confusing, and also the runtime creation of functions. But this passes all the tests, and I tried to break it manually, and couldn't. Must be good :)

@ajpotts ajpotts force-pushed the 3886_refactor_idxReductionMsg branch from 51a7e06 to d787291 Compare November 20, 2024 16:51
@ajpotts ajpotts added this pull request to the merge queue Nov 20, 2024
Merged via the queue into Bears-R-Us:master with commit b456d3e Nov 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drculhane drculhane drculhane approved these changes

@jaketrookman jaketrookman jaketrookman approved these changes

@stress-tess stress-tess stress-tess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor idxReductionMsg
4 participants
@ajpotts @stress-tess @jaketrookman @drculhane